Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368481

Summary:	Re-examine localStorage caching and lifecycle
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Simon Kaegi <simon_kaegi>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, grant_gayed, malgorzata.tomczyk, simon_kaegi
Version:	0.3	Keywords:	usability
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2012-01-12 14:23:20 EST

Every now and then (!?!) I notice that my favorites go missing.  And then they come back. 

It happened yesterday after a session of being logged into Anton's Orion to look at his site and code.  

And it happened around the time that I was reading the N&N page that John published from an Orion site.

So I'm wondering if the localStorage for preferences is keyed by something that doesn't include the user name.  Could using Anton's install have wiped out my preferences, and then they were empty until I did something to fetch the server-stored preferences back?

Comment 1 Susan McCourt

2012-01-13 12:15:18 EST

I think my theory about running someone else's Orion is bogus.  Perhaps this happens more frequently than I think.  It happened this morning (does it happen on every new build?)

Comment 2 John Arthorne

2012-01-13 15:25:37 EST

FWIW I have favorites I created on orion.eclipse.org I created months ago that I have never lost. I wonder if something you're doing with your "inner" site is interfering?

Comment 3 Susan McCourt

2012-01-13 15:56:44 EST

I never lose them per se, I can get them right back by reloading the page.  It seems like when I log in after a new build has been deployed, my favorites are usually empty and then a reload gets them back.  But there definitely could be some inner site stuff at play.

Comment 4 Susan McCourt

2012-04-26 13:53:00 EDT

I think this is just a "first time you use the server."  It happens every time a build is deployed.  Not only does the favorites pane not fill in, but if you use "Ctrl+Shift+F" there are no favorites in that list either.

Could be a race condition with the favorites cache, or something like that...I will revisit the flow.

Comment 5 Susan McCourt

2012-05-21 16:48:58 EDT

I think what's going on here is that the favorites service doesn't try to use an authenticated service, so it just loads "no favorites."  Then the nav tries to use the file service, and you authenticate.  Now the nav loads, but the favorites is showing the stale data.

Simon, is there anything in the new login sequence cycle that will help with this?

Comment 6 Susan McCourt

2012-05-23 18:17:06 EDT

Simon says he will look at this one.

Comment 7 Simon Kaegi

2012-05-23 18:20:30 EDT

The login cycle should prevent this from occuring. I suspect the problem is we're caching without responding to logout events correctly.

Comment 8 Simon Kaegi

2012-06-08 15:31:43 EDT

Moving to 1.0 -- changing title to reflect a need to re-examine how we cache in localstorage and manage the life of things we cache

Comment 9 Simon Kaegi

2012-10-03 22:18:47 EDT

The changes here are incredibly important but too risky for 1.0. This means async prefs and ad-hoc inter-tab communication via local storage for 1.0. I'm going to move to 2.0 M1.

Comment 10 John Arthorne

2015-05-05 16:30:23 EDT

This open bug report had a target milestone in the past. The target milestone has been removed. Please target for a date in the future or leave the target blank if it is not known.

Comment 11 Anton McConville

2015-05-08 11:03:06 EDT

It seems to me that the local storage caching/lifecycle isn't a problem in daily usage of Orion. This bug is a few years old. Closing.