Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368465

Summary: Import Files -RSE - Cyclic Symbolic Reference problem
Product: [Tools] Target Management Reporter: Naveen Nayak <naveensnayak>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh, pwebster
Version: unspecified   
Target Milestone: 3.4 M5   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch to avoid duplicate files none

Description Naveen Nayak CLA 2012-01-12 11:28:45 EST
Build Identifier: I20110613-1736

Ubuntu 11.10 
Sun JDK
Version: 3.7.0
Build id: I20110613-1736
Plugins: Aptana, PHP-PDT, Egit

Eclipse does not recognize cyclic symbolic link references and tries to download all the files in a loop 

I have a folder structure as follows 
/var/www/elgg
/var/www/elgg/repo -> /var/www/drupal (symlink)
/var/www/drupal/elgg -> /var/www/elgg (symlink) 

i know its not a good idea to have cyclic references in the file system - thats a totally different issue though 

eclipse should recognize the cyclic reference and not continue downloading files 

I searched and found these bugs - but there is no information on what is the final outcome 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=187318
https://bugs.eclipse.org/bugs/show_bug.cgi?id=232426

This might also be one of the reasons why we get the "enter source folder" error and a greyed-out finish button while importing files - eclipse might be going into a loop to query the directory structure - if i wait for 25 mins, then the finish button comes alive - during this time i can see "Querying" going on in the background - see this 

https://bugs.eclipse.org/bugs/show_bug.cgi?id=263436



Created a project
Import files using RSE 



Reproducible: Always

Steps to Reproduce:
1.create a simple cyclic reference in the fie system
2.create a project
3.import using RSE - remote file system
Comment 1 David McKnight CLA 2012-01-13 10:14:26 EST
Created attachment 209455 [details]
patch to avoid duplicate files
Comment 2 David McKnight CLA 2012-01-13 10:15:54 EST
I've committed the change to the HEAD stream.  Let me know whether you need this backported.
Comment 3 Naveen Nayak CLA 2012-01-13 13:54:28 EST
Thanks for the quick fix !