Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368451

Summary:	browse buttons have a delay so you can press them multiple times
Product:	[WebTools] Dali JPA Tools	Reporter:	Karen Butzke <karenfbutzke>
Component:	General	Assignee:	Karen Butzke <karenfbutzke>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jolene.moffitt
Version:	unspecified
Target Milestone:	3.2 M5
Hardware:	PC
OS:	Windows XP
Whiteboard:	wtp4x

Description Karen Butzke

2012-01-12 08:51:08 EST

Using eclipse 4.2 our Browse buttons for packages and types are sluggish and the mouse hourglass does not appear. Thus you can press a browse button multiple times before the dialog appears, then multiple dialogs appear. This does not happen with eclipse platform 3.7.

An example is the orm.xml entity-mappings section in the JPA Details view. I can press the package Browse buttons 3 times before the package dialog appears. Same thing for choosing a type for an entity, managed to get 6 type choosers there.

Comment 1 Karen Butzke

2012-01-12 09:22:48 EST

I have no clue why in Pane we would be running button actions using SWTUtil.asyncExec(Runnable). Changing these calls to SWTUtil.syncExec(Runnable) fixes this issue. Anyone know of a reason not to do this?

Comment 2 Karen Butzke

2012-01-17 16:34:26 EST

I have changed these buttons to just run the action, no need to call asyncExec or syncExec. If the button has been pressed then you are already on the UI thread.

Comment 3 Jolene Moffitt

2012-02-01 13:37:51 EST

Verified in Build I-3.4.0-20120201114319 

Verified when you click on a Browse button there is no delay and only one dialog appears and becomes the focus.  See the link to view test steps for verification.  http://wiki.eclipse.org/Dali_3.2_M5