Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368355

Summary: Provide filter mechanism to perspective action bar
Product: [WebTools] WTP Java EE Tools Reporter: Chuck Bridgham <cbridgha>
Component: jst.j2eeAssignee: Chuck Bridgham <cbridgha>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, kaloyan
Version: 3.2.5Flags: cbridgha: pmc_approved? (david_williams)
cbridgha: pmc_approved? (raghunathan.srinivasan)
cbridgha: pmc_approved? (naci.dai)
cbridgha: pmc_approved? (deboer)
cbridgha: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
cbridgha: pmc_approved? (cbridgha)
ccc: review+
Target Milestone: 3.3.2   
Hardware: PC   
OS: Windows 7   
Whiteboard: PMC_Approved
Bug Depends on:    
Bug Blocks: 368391    
Attachments:
Description Flags
patch
none
cleaned up patch none

Description Chuck Bridgham CLA 2012-01-11 10:01:44 EST 
Adopters have the ability to hide actions / wizards in their products through the "capabilities" mechanism's, which give the ability to hide through the standard "new" -> "project" etc.. tree format...

This mechanism fails for action bar's that are constructed in the Java EE perspective.

A new extension point can enable adopters to register any new project wizard id they wish to hide.  

By default, no behavior will change.
Comment 1 Chuck Bridgham CLA 2012-01-11 10:23:00 EST 
Created attachment 209315 [details]
patch

This includes the new extension point, and extra check while building the Java EE Action bar used in the JavaEE perspective.

The extension point grammar looks like this if for instance an adopter would like to filter the "static web project" action:

<extension
        point="org.eclipse.jst.j2ee.ui.newjavaeeactionfilter">
     <newjavaeewizardId   filterwizard="org.eclipse.wst.web.ui.internal.wizards.SimpleWebProjectWizard">
     </newjavaeewizardId>
  </extension>
Comment 2 Chuck Bridgham CLA 2012-01-11 10:23:47 EST 
Asking for review from Carl, and after I will submit to PMC because this is a new ext point
Comment 3 Chuck Bridgham CLA 2012-01-11 13:18:06 EST 
Created attachment 209337 [details]
cleaned up patch

Tweaked naming of a few methods - cleaned up api
Comment 4 Chuck Bridgham CLA 2012-01-11 14:32:30 EST 
Putting up for PMC review:

1) Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

An adopter product has implemented a wizard that replaces function from WTP, and would like to only highlight the adopter action in their product.  Capabilities are used to perform 90% of this, but are not sufficient for hiding the drop-down action bar in the Java EE perspective.


2) Is there a work-around? If so, why do you believe the work-around is insufficient?
No


3) How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?
The fix effects UI(filtering menu items) - we have performed manual testing


4) Give a brief technical overview. Who has reviewed this fix?

A new extension point is now available to enable adopters to register Wizard id's they wish to filter used in the Action bar.  By default the menu will be unchanged


5) What is the risk associated with this fix?
None
Comment 5 Chuck Bridgham CLA 2012-01-12 11:30:08 EST 
Committed to both R3_3_Maintenance and HEAD