Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368340

Summary:	Many ComposedAdapterFactory instantiations without disposal
Product:	[Modeling] ECP	Reporter:	Nikolay Kasyanov <corrmage>
Component:	Common	Assignee:	Edgar Mueller <emueller>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jhelming
Version:	unspecified
Target Milestone:	1.0.0
Hardware:	All
OS:	All
Whiteboard:

Description Nikolay Kasyanov

2012-01-11 08:53:48 EST

I've found that ComposedAdapterFactory instantiated in many places, but not disposed later. It may result in item provider leaks.
May be it would be nice to create one global instance of ComposedAdapterFactory, and use it everywhere.

Comment 1 Jonas Helming

2012-01-13 05:44:14 EST

we removed a lot of those occurences, but thanks, we will look into

Comment 2 Nikolay Kasyanov

2012-02-04 03:15:39 EST

Found another non-disposed instantiations — new ComposedAdapterFactory doesn't assigned to any variable:
org.eclipse.emf.ecp.common.MEClassLabelProvider:29
org.eclipse.emf.ecp.common.util.ModelElementTooltip:27
org.eclipse.emf.ecp.common.utilities.DefaultLabelProvider:26
org.eclipse.emf.ecp.common.utilities.ShortLabelProvider:28
org.eclipse.emf.ecp.editor.RelevanceWrappedLabelProvider:35
org.eclipse.emf.ecp.navigator.TreeContentProvider:116
org.eclipse.emf.ecp.navigator.wizards.ModelTreeContentProvider:43

Comment 3 Nikolay Kasyanov

2012-02-04 03:17:19 EST

oops, more:
org.eclipse.emf.ecp.validation.providers.ValidationContentProvider:26
org.eclipse.emf.ecp.validation.providers.ValidationLabelProvider:30

Comment 4 Eugen Neufeld

2013-05-17 09:53:37 EDT

Should be fixed now.