Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368323

Summary: Find a common place for [...]-mbean.properties and *MBean.java
Product: [RT] Jetty Reporter: Thomas Becker <tbecker>
Component: otherAssignee: Project Inbox <jetty-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: trivial    
Priority: P3 CC: gregw
Version: unspecified   
Target Milestone: 7.5.x   
Hardware: All   
OS: All   
Whiteboard:

Description Thomas Becker CLA 2012-01-11 04:21:10 EST 
Build Identifier: 

Some [...]-mbean.properties files are stored inside the jetty-jmx module (e.g. the ones for Logging). Some are inside the specific module they belong to (e.g. DeploymentManager-mbean.properties. 

Both make sense, but we should have a common place for them. Either we place all of them together with the corresponging *MBean.java files in jetty-jmx or in the modules they belong to.

Reproducible: Always
Comment 1 Greg Wilkins CLA 2012-01-11 20:28:41 EST 
thomas,

the logic of the current setup is that jetty-jmx should contain mbean definitions only for entities that are from modules below the level of jetty-jmx (which i think it only util). All other modules should have their own mbean definitions.

jetty-util could have it's own mbean property files, as they do not compile, but it could not have anything dependent on ObjectMBean.

Perhaps this should be documented in the jetty-jmx module.
Comment 2 Thomas Becker CLA 2012-01-12 04:07:24 EST 
Yes, I saw that. Because you'll get a dependency loop if you create a jetty-jmx dependency in jetty-util.

But shouldn't we move all mbean stuff to jetty-jmx just for convenience?
Comment 3 Greg Wilkins CLA 2012-01-18 01:29:56 EST 
It is not possible to have "all" mbean stuff in jetty-jmx.  For example, 3rd party modules cannot have their mbean stuff in there.   So it is better to have the mbean meta data in the modules with the classes the implement them - so they can be released and maintained together.