Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368295

Summary:

all results returned when querying for user but not specifying the fields to search

Product:

z_Archived

Reporter:

Miles Parker <milesparker>

Component:

Mylyn

Assignee:

Frank Becker <eclipse>

Status:

RESOLVED FIXED

QA Contact:

Severity:

minor

Priority:

CC:

eclipse, steffen.pingel

Version:

unspecified

Target Milestone:

3.7

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

378474

Attachments:

Description	Flags
mylyn/context/zip	none
error not cleared	none
mylyn/context/zip	none

Description Miles Parker

2012-01-10 16:00:13 EST

When searching against Bugzilla for a query I noticed this:

1. Create a new "Query using Form"
2. Enter an email address and "contains".
3. Do not check any checkboxes, e.g. Owner, Reporter..

The results come back with all entries in Bugzilla. :O My expectation would be that there would be no results.

Comment 1 Steffen Pingel

2012-01-11 05:45:35 EST

The behavior is as design but I would argue that there is a lack of input validation. It doesn't make much sense to provide an email address but to not check off one of the boxes. Frank, how difficult would it be to add that?

Comment 2 Miles Parker

2012-01-11 12:28:52 EST

Oh you're right -- the bugzilla "ui" does this as well. :O I'm not sure I'd call it as much 'by design' as 'by default' as it looks like the bugzilla query doesn't really seem to have a validation step -- it just builds up the query statement as best as it can from the information that the dumb user gives it.

If the form is meant to be a direct analog of the bugzilla UI then I'd say leave it alone. If there is already a validation step in there, then I'd say add it.

Comment 3 Frank Becker

2012-01-11 16:28:46 EST

I start with this tomorrow!

I think that is an bug, because we only add selected buttons to the query.

Maybe I only have to move 3 statement into an if block (two times).

Comment 4 Frank Becker

2012-01-13 11:31:11 EST

I add an ErrorDialog when validating in Search mode fails.

Comment 5 Frank Becker

2012-01-13 11:31:14 EST

Created attachment 209463 [details]
mylyn/context/zip

Comment 6 Steffen Pingel

2012-02-16 05:32:25 EST

Created attachment 211093 [details]
error not cleared

Comment 7 Steffen Pingel

2012-02-16 05:33:50 EST

It looked like validation works but the error didn't get cleared when I selected Reporter (Finish was enabled though). Since I didn't do anything wrong this should not be an error but a standard message.

Comment 8 Frank Becker

2012-02-17 13:42:08 EST

Fixed with new push (id=d1d4e9582e26e9c5564460124a812c2a9b708af5)

Comment 9 Frank Becker

2012-02-17 13:42:10 EST

Created attachment 211204 [details]
mylyn/context/zip