Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368282

Summary: meaning of "root" in navigator when there are multiple file systems
Product: [ECD] Orion Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: john.arthorne, ken_walker, libingw, simon_kaegi
Version: 0.3   
Target Milestone: 0.4 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Susan McCourt CLA 2012-01-10 13:10:33 EST
Our navigator model is fairly broken/bogus when there are multiple file systems involved.  Problems include:

- the user's concept of root is different in a single file system vs. multi file system situation.  When a single file system is installed, the "root" means the workspace, or all top level folders/projects.  But when an additional file system is installed, suddenly there is a new level of top level folders that represent file systems.
- the breadcrumb does not represent these multiple levels.  If I open a navigator with no resource, I see the multi rooted tree and the breadcrumb says "root."  If I click on the Orion file server, then I see the familiar list of projects but the breadcrumb says "root" still.  No way to move back up.  

In bug 361856 I added file system roots to the left hand pane.  So I propose that we change the way the nav roots are computed as follows:

- the navigator is always trafficking in a single file system
- the left hand pane is used to pick which one
- "root" in the breadcrumb refers to the root of a particular file system.  We should probably rename "root" to the name of the file system.  Such as 
Orion Projects/foo/bar
WebDAV Folders/baz/boo
RTC/blah/bar

I think I can take care of this, just wanted to get agreement first.
Comment 1 Susan McCourt CLA 2012-01-10 13:31:59 EST
John, Simon, Ken....does this sound about right?
Comment 2 Susan McCourt CLA 2012-01-10 13:35:01 EST
I also propose that when the user clicks on the "Navigator" link or otherwise types a URL that doesn't specify the top level of a file system, we just pick the first file system found.  We could also consider a preference where you could set your default file system.  The user always has to use the left hand pane to change to a different file system.  Having the name of the file system in the breadcrumb helps orient as to where you are.

This certainly seems better than what we have today and we can iterate further once we're using it.
Comment 3 libing wang CLA 2012-01-10 13:54:58 EST
Susan, I've got 2 questions here :
1.Will Bug 367883 depend on this? I havn't looked at it yet but my guess is the file service got lost in the multiple file system.
If we will have right pane always referring to one file system, my guess is there will be only one file service there. 
2.Not sure if the new design will affect scoped search but we should make that sure.
Comment 4 Susan McCourt CLA 2012-01-10 14:54:06 EST
(In reply to comment #3)
> Susan, I've got 2 questions here :
> 1.Will Bug 367883 depend on this? I havn't looked at it yet but my guess is the
> file service got lost in the multiple file system.
> If we will have right pane always referring to one file system, my guess is
> there will be only one file service there. 
> 2.Not sure if the new design will affect scoped search but we should make that
> sure.

The symptom for that bug is different with this bug implemented, but it doesn't change the basic problem that the search location stuff is not taking file system URL into account.  I'll annotate that bug with more detail.
Comment 5 Susan McCourt CLA 2012-01-10 15:48:34 EST
I've released this code.  Note that the only change you'll notice if you run one file system is that the root of the breadcrumb is now called "Orion Projects" because that is the file service's name.

For multi-file plugin systems, we now default the meaning of "" (a navigator with no location specified) to mean "the first file service root."  In case we need to do some testing or other work with the multi rooted tree, I have special cased the path "/" to mean "the multi file service root" rather than "" as it was before.  This way, the casual user and all the default links will take you to the default contents and you can use the new top pane navigator to traverse file systems.  But in case we need to continue working with the multi rooted tree (or even expose to advanced users) we can type something like
http://susan.orion.eclipse.org:8080/navigate/table.html#/

Other notes:
- we need to figure out how scoped search should work in multi file systems, see bug 367883
- we probably want the directory prompter to support the "multi file system" root so that someone could move copy across file systems (this function seems to be implemented in file client).  Note that directory prompter doesn't work at all with multi file systems right now (bug 364175)
Comment 6 Susan McCourt CLA 2012-01-10 15:51:50 EST
(In reply to comment #5)
> - we probably want the directory prompter to support the "multi file system"
> root so that someone could move copy across file systems (this function seems
> to be implemented in file client).  Note that directory prompter doesn't work
> at all with multi file systems right now (bug 364175)
actually I meant bug 368294