Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368251

Summary:	Two versions of the same bundle are listed in bundles.info
Product:	[Eclipse Project] Equinox	Reporter:	Mauro Molinari <mauromol>
Component:	p2	Assignee:	P2 Inbox <equinox.p2-inbox>
Status:	CLOSED NOT_ECLIPSE	QA Contact:
Severity:	normal
Priority:	P3	CC:	andrew.eisenberg, irbull, krzysztof.daniel, tjwatson
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mauro Molinari

2012-01-10 09:16:30 EST

Build Identifier: M20110909-1335

I encountered bug 365722.
After inverstigation, Thomas Watson determined that the cited bug is caused by the presence of two different versions of org.codehaus.groovy.frameworkadapter framework extension listed in my <eclipse dir>/configuration/org.eclipse.equinox.simpleconfigurator/bundles.info file:

org.codehaus.groovy.frameworkadapter,2.5.2.xx-20110921-1600-e37,plugins/org.codehaus.groovy.frameworkadapter_2.5.2.xx-20110921-1600-e37.jar,4,false
org.codehaus.groovy.frameworkadapter,2.6.1.xx-20120107-0800-e37,plugins/org.codehaus.groovy.frameworkadapter_2.6.1.xx-20120107-0800-e37.jar,4,false

I already opened the following bug to the Groovy Eclipse plugin team:
http://jira.codehaus.org/browse/GRECLIPSE-1325
because it's not clear if this situation is "normal" or not.

Anyway, Thomas Watson suggested to also open a bug for p2 to see if there's a problem here that can lead to that situation (maybe bad metadata in the p2 repositories?).

Please consider that:
- version 2.5.2 of the Groovy Eclipse plugin was installed from the update site at http://dist.springsource.org/release/GRECLIPSE/e3.7/
- version 2.6.1 of the Groovy Eclipse plugin was installed from the update site at http://dist.codehaus.org/groovy/distributions/greclipse/snapshot/e3.7/

Reproducible: Didn't try

Steps to Reproduce:
Unfortunately, I do not have steps to reproduce.

Comment 1 Ian Bull

2012-02-14 12:11:01 EST

I've seen cases where bundles fail to be removed from bundles.info when an update occurs. This usually happens if someone is creating their own provisioning plan (programatically) and not careful about the additions/removals. 

However, if you are using p2 applications (the UI or the director) then I haven't heard of this problem. Do you know if this is still an issue?

Comment 2 Mauro Molinari

2012-02-14 12:33:30 EST

Well, thanks to the help of Andrew Eisenberg of GRECLIPSE, I solved in this way:
- uninstalled the GRECLIPSE plugin
- closed Eclipse
- removed all the JARs in the plugin folder
- removed all the duplicate entries in bundles.info
- re-run Eclipse
- reinstalled the latest version of GRECLIPSE plugin

Talking with Andrew, he changed its framework adapter so that it's a singleton now: this should avoid the problem to occur again in the future (I hope to have written it right, I do nothing about p2 and Eclipse bundles from a technical point of view).

However, the purpose of this bug was to say: this situation can occur and this leads to bug 365722. Maybe p2 should avoid that in some way...

Comment 3 Krzysztof Daniel

2013-08-13 06:46:31 EDT

(In reply to comment #0)
> Please consider that:
> - version 2.5.2 of the Groovy Eclipse plugin was installed [...]
> - version 2.6.1 of the Groovy Eclipse plugin was installed [...]

(In reply to comment #2)
> 
> Talking with Andrew, he changed its framework adapter so that it's a
> singleton now
This is a source of some (not all) evilness. If Groovy bundles were not singletons, it was perfectly OK to have more than one version installed. Comment 0 says it was the case.

> However, the purpose of this bug was to say: this situation can occur and
> this leads to bug 365722. Maybe p2 should avoid that in some way...

Bug 365722 has been fixed, so it will not cause problems anymore. P2 can't know intents of developers, and since having one non-singleton bundle installed in two versions is ok, I'm closing this bug as not_eclipse (because it was groovy plugin fault).