Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368221

Summary:

Preference option for Codan annotation markers

Product:

[Tools] CDT

Reporter:

Axel Mueller <aegges>

Component:

cdt-codan

Assignee:

Axel Mueller <aegges>

Status:

RESOLVED FIXED

QA Contact:

Elena Laskavaia <elaskavaia.cdt>

Severity:

enhancement

Priority:

CC:

cdtdoug, eclipse.sprigogin, malaperle, yevshif

Version:

8.0

Target Milestone:

8.2

Hardware:

OS:

All

Whiteboard:

Attachments:

Description	Flags
preferences for CODAN annotations	cdtdoug: iplog+

Description Axel Mueller

2012-01-10 03:32:07 EST

Build Identifier: CDT 8.0.1

In Preferences->General->Editors->Text Editors->Annotations I can choose color and style for compiler errors etc. I would like to have an option to modify the color of CODAN errors.

Motivation:
At the moment it is not possible to distinguish between compiler and CODAN errors in the overview ruler (right side of the editor) because they use the same color. So you have to check each marker to see what kind of error type it is. That's very annoying when the opened file contains many CODAN errors (due to missing include, incomplete indexer etc.) and you want to check if there are any compiler errors.

BTW, Bug #329430 was about changing the icons for CODAN markers to better distinguish them from compiler errors (useful for the vertical ruler on the left side).



Reproducible: Always

Comment 1 Axel Mueller

2013-05-01 16:24:45 EDT

Created attachment 230364 [details]
preferences for CODAN annotations

I added preferences for CODAN error and warning markers. The default prefs are identical to the current ones. But now the user can 
- disable overview and vertical ruler
- disable text marker
- define the color and type of text marker

Modified values are saved in workspace.

Comment 2 Sergey Prigogin

2013-05-01 18:33:13 EDT

Please push the patch to Gerrit.

Comment 3 Axel Mueller

2013-05-02 06:46:39 EDT

(In reply to comment #2)
> Please push the patch to Gerrit.
After struggling for nearly an hour I was able to push the patch to gerrit. 
Change-Id: I09a45a775b7dfa1d6bafabb65709da0b189b3613

Comment 4 Axel Mueller

2013-05-03 17:40:53 EDT

Fixed
https://git.eclipse.org/r/#/c/12511/

Comment 5 Elena Laskavaia

2013-05-05 20:37:26 EDT

Last time I tried that (not having super in marker) it caused errors
not to show up on resources properly (i.e. in navigator) 
and quick fix was not working, is this working correctly now with this fix?

Comment 6 Axel Mueller

2013-05-06 07:36:46 EDT

(In reply to comment #5)
> Last time I tried that (not having super in marker) it caused errors
> not to show up on resources properly (i.e. in navigator) 
> and quick fix was not working, is this working correctly now with this fix?
I did not encounter problems with resource decorations. About quick fix I am unsure. I did not check.

Comment 7 Axel Mueller

2013-05-06 17:32:31 EDT

(In reply to comment #6)
> About quick fix I am
> unsure. I did not check.
There is no problem here, too. Quick fix works.

Comment 8 Sergey Prigogin

2013-05-19 13:02:35 EDT

The patch resulted in breaking "Ctrl+." and "Ctrl+," navigation to the next/previous error in the editor.

Comment 9 Axel Mueller

2013-05-20 08:09:29 EDT

Pushed patch to Gerrit https://git.eclipse.org/r/#/c/12979/

Comment 10 Marc-André Laperle

2013-05-29 17:07:36 EDT

The last patch has been merged.