Bug 368186

Comment 1 John Arthorne 2012-01-10 09:25:47 EST

This looks like the culprit:

     [java] Tracing dependencies for: table
     [java] org.mozilla.javascript.WrappedException: Wrapped java.io.FileNotFoundException: /opt/public/eclipse/e4/orion/I201201092230/optimizat
ion/./navigate/./jsdiff/diff.js (No such file or directory)
     [java]     at org.mozilla.javascript.Context.throwAsScriptRuntimeEx(Context.java:1773)
     [java]     at org.mozilla.javascript.MemberBox.newInstance(MemberBox.java:202)
     [java]     at org.mozilla.javascript.NativeJavaClass.constructSpecific(NativeJavaClass.java:281)
     [java]     at org.mozilla.javascript.NativeJavaClass.construct(NativeJavaClass.java:200)
     [java]     at org.mozilla.javascript.ScriptRuntime.newObject(ScriptRuntime.java:2327)
     [java]     at org.mozilla.javascript.gen.c13._c12(Unknown Source)
     [java]     at org.mozilla.javascript.gen.c13.call(Unknown Source)
     [java]     at org.mozilla.javascript.optimizer.OptRuntime.call1(OptRuntime.java:66)

Comment 2 John Arthorne 2012-01-10 09:37:34 EST

So this is the optimization for the navigate page ("table"). I'm wondering why this is pulling in jsdiff at all.

Comment 3 libing wang 2012-01-10 11:55:42 EST

(In reply to comment #2)
> So this is the optimization for the navigate page ("table"). I'm wondering why
> this is pulling in jsdiff at all.

Here is the requireJS dependency chain:
table.js -> searchClient.js -> searchExplorer.js -> compare-container.js -> jsdiffAdapter.js -> jsdiff/diff.js

The reason is that the search replace preview requires the compare widget, which eventually requires jsdiff.

Comment 4 John Arthorne 2012-01-10 13:18:22 EST

I'm not understanding why the module loader isn't finding the dependency. jsdiffAdapter.js has this:

define(['jsdiff/diff']

table.html has this:

		require({
		  baseUrl: '..',


So from this I would expect to find the script at:

navigate/../jsdiff/diff.js

This is where the script is located. However in the build log I see it is looking under:

navigate/./jsdiff/diff.js

Which is the wrong place.  I'll need to go over this with Simon.

Comment 5 John Arthorne 2012-01-11 17:24:05 EST

Simon tracked this down and we are fixing it.

Comment 6 John Arthorne 2012-01-11 17:26:02 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=56d6893058e944ae7e4d63ba599d90dabe9b14bf

Comment 7 John Arthorne 2012-01-12 09:50:50 EST

Not fixed.

Comment 8 John Arthorne 2012-01-16 09:47:44 EST

This was fixed by Ken and Simon.