Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368107

Summary: Check child nodes when parent node is checked.
Product: z_Archived Reporter: Daniel Egger <daniel.egger>
Component: ScoutAssignee: Project Inbox <scout.core-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jeremie.bresson, stephan.merkli
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 415320    
Bug Blocks:    
Attachments:
Description Flags
Patch for abstract tree
none
Patch for AbstractTreeBox / ITreeBox
none
Example form to test new behavior
none
JUnit Test none

Description Daniel Egger CLA 2012-01-08 12:00:11 EST
Created attachment 209177 [details]
Patch for abstract tree
Comment 1 Daniel Egger CLA 2012-01-08 12:03:28 EST
The attached patch will add a new method named
getConfiguredCheckChildren

If getConfiguredCheckChildren is set to true then the checking behaviour will change for TreeNodes which also have child-nodes.
All the child-nodes will get checked if the parent-node gets checked.
All the child-nodes will get unchecked if the parent-node gets unchecked.
Comment 2 Stephan Merkli CLA 2013-07-08 03:02:57 EDT
Created attachment 233194 [details]
Patch for AbstractTreeBox / ITreeBox

Thanks for the initial patch, added revised patch working with AbstractTreeBox instead of AbstractTree.
Comment 3 Stephan Merkli CLA 2013-07-08 03:04:21 EDT
Created attachment 233195 [details]
Example form to test new behavior
Comment 4 Stephan Merkli CLA 2013-08-13 04:24:24 EDT
Created attachment 234342 [details]
JUnit Test
Comment 5 Stephan Merkli CLA 2013-08-13 04:26:52 EDT
@Jérémie: please add JUnit test to Scout 3.9 / 3.10 GIT repo and cherry pick SVN revisions 3513 & 3517. Thanks.
Comment 6 Jeremie Bresson CLA 2013-08-19 05:36:33 EDT
The patch for 3.9.1 is staged on GitHub:
https://github.com/BSI-Business-Systems-Integration-AG/scout.rt/commit/91ab74776dc0ce8ac7f0cd506f03f41df262021e

For the moment, when I try to push it on Eclipse Gerrit, I get this error:

**************
Reviewing commit: commit 91ab74776dc0ce8ac7f0cd506f03f41df262021e 1376397393 ----sp
Authored by: Stephan Merkli <sme@bsiag.com>

error: The author does not have a Gerrit account.
All authors must either be a commiter on the project, or have a current CLA on file.
**************

Waiting for bug 415320.
Comment 7 Jeremie Bresson CLA 2013-08-19 16:14:42 EDT
Change for 3.9.1:
https://git.eclipse.org/r/15624
Comment 8 Jeremie Bresson CLA 2013-08-19 16:46:07 EDT
Change for 3.10.0:
https://git.eclipse.org/r/15625
Comment 9 Jeremie Bresson CLA 2013-08-19 17:04:05 EDT
Pushed with commits:

For 3.9.1: c0a0c052b3f727b6a77701eaf27d9e36a32d825b
For 3.10.0: 68ff3ad8f244d45bd7f1f9d501039089d17c46a2

@Stephan Merkli:
Can you please verify ?
Comment 10 Stephan Merkli CLA 2013-09-02 04:10:16 EDT
Thanks Jérémie for adding to 3.9 / 3.10.
Comment 11 Matthias Zimmermann CLA 2014-07-01 03:17:51 EDT
Shipped with Eclipse Luna Release