Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368083

Summary: remove usePdeSourceRoots compile and source mojo configuration parameters
Product: z_Archived Reporter: Igor Fedorenko <igor>
Component: TychoAssignee: Jan Sievers <jan.sievers>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: benjamingnau, jan.sievers, t-oberlies
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Igor Fedorenko CLA 2012-01-07 09:52:44 EST 
As discussed on tycho-dev [1], there is an inconsistency between  tycho-compile-plugin and tycho-sources-plugin usePdeSourceRoots parameters. Since these parameters do not appear to be useful, removing the parameters is the best way to reconcile the inconsistency.


[1] http://dev.eclipse.org/mhonarc/lists/tycho-dev/msg00432.html
Comment 1 Tobias Oberlies CLA 2012-01-07 10:14:42 EST 
So what will be the behaviour: like with usePdeSourceRoots=true?
Comment 2 Igor Fedorenko CLA 2012-01-07 10:54:19 EST 
yes.
Comment 4 Benjamin Gnau CLA 2012-10-25 13:00:47 EDT 
After upgrading to this 'fix', our Clover builds now no longer work because tycho-compiler no longer obeys the Maven sourceDirectory property. Because the point of Clover (and other metric tools) is to instrument source code, the directory for the resultant code must of course be different than the starting directory. I've tried adding a new src directory in the build.properties file, but this causes unnecessary havoc when not compiling with Clover enabled, and requires a lot of other hoops to be jumped through in the configuration files.

If this won't be reverted to allow source code instrumenting plugins to function correctly, can I be given a workaround that will let me change the source directory at the POM level?
Comment 5 Jan Sievers CLA 2012-10-26 03:42:36 EDT 
(In reply to comment #4)
> After upgrading to this 'fix', our Clover builds now no longer work because
> tycho-compiler no longer obeys the Maven sourceDirectory property. Because
> the point of Clover (and other metric tools) is to instrument source code,
> the directory for the resultant code must of course be different than the
> starting directory. I've tried adding a new src directory in the
> build.properties file, but this causes unnecessary havoc when not compiling
> with Clover enabled, and requires a lot of other hoops to be jumped through
> in the configuration files.
> 
> If this won't be reverted to allow source code instrumenting plugins to
> function correctly, can I be given a workaround that will let me change the
> source directory at the POM level?

you can still configure source roots at the pom level. Tycho will _add_ source roots from build.properties to these in the maven project model.
If that does not help, make sure to provide a small example to reproduce your problem and open a new bug as this one is resolved.
Provide steps to reproduce as well as expected vs. observed behaviour.

BTW your displayed bugzilla login "Missing name" is disqualifying.
Comment 6 Benjamin Gnau CLA 2012-10-26 08:24:38 EDT 
Thanks for the quick reply, Jan. Yes, I mentioned that I tried working around this by putting more directories in the build.properties file, but that didn't work well because the instrumented code is created during a specific Maven build, and causes issues with Eclipse compiling when these files haven't been created. I guess I wasn't correctly conveying what I meant by 'POM level', as I was trying to ask for something I could configure in Maven/in POM alone (as to not disturb our developers building through Eclipse for the previous reason) to remedy the issue.

I will open up a new bug report when I get the time to do so.

I guess 'Missing Name' is the default when you don't enter anything in for a name, I've updated the field, thanks.