Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368073

Summary:	Allow users to opt out of uploading download statistics
Product:	[Eclipse Project] Equinox	Reporter:	Angel Roman <Angel.Roman>
Component:	p2	Assignee:	Sebastian Ratz <sebastian.ratz>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	denis.roy, irbull, kane.mx, kane.zhu, mistria, remy.suen
Version:	unspecified
Target Milestone:	4.24 M1
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Angel Roman

2012-01-07 00:04:54 EST

Build Identifier: Version: Indigo Release Build id: 20110615-0604

It would be courteous and respectful for p2 to allow  users to opt out of uploading any information similar to how UDC allows the user to turn it off. For automated builds it would be convenient for the p2 director to support a command line argument to disable upload of statistics.

At the very least, a check for whether the repository is remote or local could be used to the determine if an attempt to upload stats should be made.

Granted, one can make the argument that archived repositories for local use should not include the p2.statsURI property in their artifacts.xml.

The code in the indigo release show MirrorRequest::collectStats() called even when using a local file:/// repository. This causes an exception to be thrown, caught, and logged when performing a build on a machine without internet access.




Reproducible: Always

Steps to Reproduce:
Copy an archived repository with the p2.statsURI property set to a machine without internet access.

Perform an installation of an IU via the p2 director.

Watch exception printed on the screen.

Comment 1 Meng Xin Zhu

2012-01-10 01:45:15 EST

Looks like you mirrored p2 repository to local. Assuming you should be able to modify your local p2 repository, you can disable the downloading stats via removing the 'p2.statsURI' property from your local artifacts.xml.

Comment 2 Angel Roman

2012-01-10 03:29:26 EST

Correct. This works and am currently doing this in my automated build, however, I'll leave it to the p2 team to determine whether this is a workaround or a solution.

Regards,
Angel

Comment 3 Eclipse Genie

2019-10-13 17:57:02 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Mickael Istria

2022-03-28 09:49:16 EDT

Thanks Sebastian! Fix is https://github.com/eclipse-equinox/p2/commit/e36467ef161a059b920fdb33d505e0349831d2ce

Comment 5 Sebastian Ratz

2022-03-28 09:55:13 EDT

I have documented the new option here: https://wiki.eclipse.org/Equinox/p2/HiddenOptions

Is there any other place documentation?

Comment 6 Mickael Istria

2022-03-28 09:56:33 EDT

(In reply to Sebastian Ratz from comment #5)
> Is there any other place documentation?

Maybe some page on help.eclipse.org would be a good fit? At least, those pages are usually more maintained than the wiki.