Bug 368048

Comment 1 Andrea Ross 2012-02-10 15:04:20 EST

increasing priority on this ticket

Comment 2 Thanh Ha 2012-02-28 15:50:45 EST

Created attachment 211763 [details]
Contains a list of files that changed since upstream M4 for Eclipse 3.x

Attached R3_M4-diffs.zip which contains a list of files that changed since upstream M4 for Eclipse 3.x

I used "git log" to find the first commit in each repo that was not by Igor to get a difference list of what changed since we pulled the M4 repos.

I then used "git diff --stat <commit>" to find a list of all the files that were changed.

Comment 3 Thanh Ha 2012-02-29 13:26:25 EST

Successfully created a script to import the headers into the POM files which requires only 2 steps:

1. Find out what files changed.

git diff --name-only 0d06e217afce062498a63489aa159305075cdc42

Replace the commit hash with one before Igor's first commit.

2. Insert headers

for i in `cat /tmp/changes` ; do ; sed '1r /home/user/eclipse/EDL_header.txt' < $i > $i.tmp ; mv $i.tmp $i ; done

Tested successfully with eclipse.jdt repo so far. Having issues committing to the repo though see my comments in Bug 372738 for further details.

Comment 4 Thanh Ha 2012-02-29 13:26:55 EST

Created attachment 211827 [details]
EDL_header.txt

Comment 5 Andrea Ross 2012-03-01 09:11:36 EST

I think we should do the EDL header as a comment in the pom.xml files to denote that file itself is covered under the EDL.

This does raise whether we should specify the project license in the pom.xml files. Thanh & I talked about this and it appears it isn't set already. At the moment, I don't have strong feelings about whether it should be set or not but am leaning towards no since the existing headers in other files should already be sufficient and I believe most people consume the Eclipse platform as a p2 repository rather than jar file(s) thus the extra meta data is of dubious value.

Comment 6 Andrea Ross 2012-03-01 12:12:09 EST

/***********************************************************************
 * Copyright (c) 2012 Eclipse Foundation.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Eclipse Distribution License v1.0
 * which accompanies this distribution, and is available at
 * http://www.eclipse.org/org/documents/edl-v10.php
 *
 * Contributors:
 *    Igor Fedorenko - initial implementation
 ***********************************************************************

Comment 7 Thanh Ha 2012-03-02 13:11:33 EST

Headers have been added in both the R4 and R3 repositories.