Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 368001

Summary:	Only use contextKey to load parts in the file being displayed in VE
Product:	z_Archived	Reporter:	Tony Chen <chenzhh>
Component:	EDT	Assignee:	Huang Ji Yong <hjiyong>
Status:	CLOSED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	hjiyong, svihovec
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	RUI_Optimization
Bug Depends on:	368555
Bug Blocks:

Description Tony Chen

2012-01-06 01:58:12 EST

In VE design/preview mode, we are loading the dependent JS files from the context by appending a contextKey to the URL. This approach is part of the cause of the performance issue described in Bug 360348 

The contextKey is only necessary for parts that exists in the current file being displayed in VE. The handler js needs to have contextKey. And for example, a record was defined in the same file as the handler, that record needs to have a contextKey. Any other files, widgets from our widget project for example, don't need contextKey.

Comment 1 Tony Chen

2012-01-06 02:04:24 EST

We probably should modify RUITemplate.generateDependentFilePath(). If the referenced part is in the same egl file as handler, then it needs contextKey, otherwise not. 

Be sure not to change the sequence of the dependent file list when adding this logic.

Comment 2 Tony Chen

2012-02-06 03:57:57 EST

How this enhancement implemented depends on what decision we come out from Bug 368555 - Investigate modular loading in HTML generator. If the modular loading is going to be done, we won't have a list of all dependencies in the HTML. In such case, we need another way to tell the loader about the contextKey. It's also a question how does the loader handler the contextKey if it is a 3rd party AMD loader. 

I'm moving this bug back to the 0.8 backlog until we have a decision in Bug 368555.

Comment 3 Tony Chen

2012-02-10 02:13:43 EST

We've decided to go forward to redesign modules using AMD API. HTMLGenerator needs to be changed to pass the contextKey to loader. Only parts that exists in the current file being displayed in VE needs to be loaded from context.

Comment 4 Huo Zhen Zhong

2012-02-22 04:21:08 EST

The context key is generated by HTML Generator, so change the owner to Ji Yong

Comment 5 Huang Ji Yong

2012-03-05 02:02:27 EST

Triage with Tony & Brian. We will only generate contextKey for current handler.
Done as child of bug 363555

Comment 6 Lisa Lasher

2012-03-30 17:52:45 EDT

close