Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367970

Summary:	Review Code Consistency in terms of Quality, Formatting, and Documentation
Product:	[ECD] Orion	Reporter:	Simon Kaegi <simon_kaegi>
Component:	Client	Assignee:	Simon Kaegi <simon_kaegi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse.felipe, john.arthorne, ken_walker, mamacdon, susan, Szymon.Brandys
Version:	0.4
Target Milestone:	3.0 RC2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	361024, 372252
Bug Blocks:

Description Simon Kaegi

2012-01-05 13:50:22 EST

As we get closer to a 1.0 release we need to take some time to look at the code in terms of ensuring we have consistency for formatting, documentation, and the quality of the code (e.g. all code must be reviewed by at least one other committer). We want the Orion code-base to be easily understandable and ensuring consistency will make both maintenance and evolving more simple without requiring the original author to always be involved.

Comment 1 Susan McCourt

2012-01-05 14:09:40 EST

- it would be good to look for copied code and try to refactor, I know we have lots of copied code across various "navigator" tables, etc.

Comment 2 Susan McCourt

2012-02-22 11:31:44 EST

(In reply to comment #1)
> - it would be good to look for copied code and try to refactor, I know we have
> lots of copied code across various "navigator" tables, etc.

opened bug 372252 for this.

Comment 3 Susan McCourt

2012-02-22 11:35:19 EST

another place to look is search "TODO"

Comment 4 Ken Walker

2012-02-23 11:17:38 EST

bogus and hack

Comment 5 Simon Kaegi

2013-06-17 14:22:49 EDT

Done for this release