Bug 367966

Comment 1 Brian Svihovec 2012-01-27 14:26:13 EST

Changing to .8 I2.  Let me know if this does not match what you are thinking.

Comment 2 Yun Feng Ma 2012-02-01 04:28:08 EST

Hi Joe,

Is the egldd entry for AS400 connection like below:

For JNDI:
    <binding name="news" type="edt.binding.as400connection" uri="jndi://as400connection1" useURI="true">
    </binding>

For AS400Connection:
    <binding name="news" type="edt.binding.as400connection" uri="" useURI="false">
      <parameters>
        <parameter name="system" value="ip"/>
        <parameter name="userId" value="abc"/>
        <parameter name="password" value="abc"/>
        <parameter name="getConnectionFromSessionPool" value="true"/>
      </parameters>
    </binding>

Comment 3 Joseph Vincens 2012-02-01 10:04:33 EST

(In reply to comment #2)
> Hi Joe,
> 
> Is the egldd entry for AS400 connection like below:
> 
> For JNDI:
>     <binding name="news" type="edt.binding.as400connection"
> uri="jndi://as400connection1" useURI="true">
>     </binding>
> 
> For AS400Connection:
>     <binding name="news" type="edt.binding.as400connection" uri=""
> useURI="false">
>       <parameters>
>         <parameter name="system" value="ip"/>
>         <parameter name="userId" value="abc"/>
>         <parameter name="password" value="abc"/>
>         <parameter name="getConnectionFromSessionPool" value="true"/>
>       </parameters>
>     </binding>

This looks good, but there are a couple of changes. I'm in the process of updating the specification, the impact to your code is minimal. Here are spec changes:
- JNDI requires websphere so there would be few users and more importantly we don't have the time to complete the development and testing so it will not be implemented in 0.8.0. 
- The parameter getConnectionFromSessionPool is removed.
- Add the parameter library type string.

I'd like to change as400connection to ibmiconnection. The pattern I've been using is: Use AS400 when a item refers to a JTOpen class or a JTOpen java doc, I use IBMi when it may be some other object. In this case a jndi connection is not an AS400 object.

Comment 4 Yun Feng Ma 2012-02-02 22:41:22 EST

Created attachment 210487 [details]
Patch

Here is a patch for this enhancement. Tony, please help review it. Thanks a lot.

Comment 5 Joseph Vincens 2012-02-07 18:05:51 EST

It looks like this is working, but I see a couple of small problems.
- In IBMiBindingWizardPage.createPasswordControl the method is doing fPasswordField.setText(getConfiguration().getUserId()) it should be using the password field fPasswordField.setText(getConfiguration().getPassword()).

- The label on the password field appears as User. IBMiConnectionBindingDetailPage.createPasswordControl uses it should use Messages.LabelPassword.

Can you commit this so we can incorporate it into a build?

Comment 6 Yun Feng Ma 2012-02-08 08:01:00 EST

Hi Jeo,

Thanks a lot for the review. I've checked in the patch, but I didn't release the new plugin (org.eclipse.edt.ide.jtopen), because I didn't see you release any JTOpen plugins, let me know if I should release it. Thanks.

Comment 7 Yun Feng Ma 2012-02-12 08:24:23 EST

Close this one, please open defect if you see any issue. Thanks.

Comment 8 Joseph Vincens 2012-02-12 10:07:22 EST

verified