Bugzilla – Full Text Bug Listing
| Summary: | PDE Build depends on org.eclipse.update* plugins | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Krzysztof Daniel <krzysztof.daniel> | ||||
| Component: | Build | Assignee: | Lars Vogel <Lars.Vogel> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | akurtakov, contact, daniel_megert, dj.houghton, Lars.Vogel, martin.skorsky, mat.booth, Vikas.Chandra | ||||
| Version: | 4.2 | Flags: | Vikas.Chandra:
review+
|
||||
| Target Milestone: | 4.8 M2 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/99444 https://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=4dc7089cc154f39572c725707ae7ea92f860e496 https://git.eclipse.org/r/111527 https://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=81ab3a383e68b037eb5a45c1a0862c72bbc2ab5e |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 311590, 366701, 518351 | ||||||
| Attachments: |
|
||||||
|
Description
Krzysztof Daniel
Created attachment 209061 [details]
Fix that removes dependency to core.update plugins (and support for old installation manager).
Note that org.eclipse.update.configurator is not going to be removed in bug 311590. Because it is re-exported by org.eclipse.core.runtime we could not remove that without breaking binary compatibility at the bundle level. However this change sounds reasonable to me. DJ, I know you had looked at removing these dependencies on platform.xml but not sure if you saw this one. If we remove these references aren't we going to be missing information? If the user has multiple sites in the platform.xml file we won't find their features. Do we need to replace this code with calls to the profile to get a list of the features which are installed? Lars, you've set the milestone to M1. Do you plan to work on this? (In reply to Dani Megert from comment #4) > Lars, you've set the milestone to M1. Do you plan to work on this? Jupp New Gerrit change created: https://git.eclipse.org/r/99444 Lars, any update on this one? (In reply to Vikas Chandra from comment #7) > Lars, any update on this one? The Gerrit awaits your feedback, see my request for feedback in the review Moving for early M2 Gerrit change https://git.eclipse.org/r/99444 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=4dc7089cc154f39572c725707ae7ea92f860e496 Pushed to master. Alex/Lars, can you verify this one? New Gerrit change created: https://git.eclipse.org/r/111527 Gerrit change https://git.eclipse.org/r/111527 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=81ab3a383e68b037eb5a45c1a0862c72bbc2ab5e |