Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367855

Summary: [terminal] TerminalActionPaste uses wrong icon for disabled state
Product: [Tools] Target Management Reporter: Anton Leherbauer <aleherb+eclipse>
Component: TerminalAssignee: dsdp.tm.core-inbox <tm.core-inbox>
Status: RESOLVED FIXED QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: minor    
Priority: P3 CC: eclipse, uwe.st
Version: 3.1   
Target Milestone: 4.0   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Anton Leherbauer CLA 2012-01-04 10:08:10 EST 
In the constructor of TerminalActionPaste the arguments to setupAction for enabledImage and disabledImage are reversed.
For some reason this seems to do no harm if the action is added to a menu, but when it is added to a toolbar, the button looks enabled although the action is in disabled state.
Comment 1 Anton Leherbauer CLA 2012-01-05 10:30:32 EST 
Created attachment 209079 [details]
Patch

This fixes the icons for the paste action.
Comment 2 Uwe Stieber CLA 2015-05-07 07:49:34 EDT 
Fixed in TM Terminal 4.0
Comment 3 Uwe Stieber CLA 2015-05-07 07:49:41 EDT 
.
Comment 4 Martin Oberhuber CLA 2015-05-22 12:06:36 EDT 
Comment on attachment 209079 [details]
Patch

Slightly different code was used to fix this issue:

http://git.eclipse.org/c/tm/org.eclipse.tm.terminal.git/commit?id=08844f654a4935c830aa37d60dc720348c6b5447

Thus marking attachment as obsolete.