Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367821

Summary:	[KeyBindings] Allow assigning key bindings to commands on other preference pages
Product:	[Eclipse Project] Platform	Reporter:	George Dinkov <go6etobate>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	enhancement
Priority:	P3	Keywords:	helpwanted
Version:	4.2
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:	stalebug

Description George Dinkov

2012-01-04 05:06:07 EST

Build Identifier: Version: Indigo Release Build id: 20110615-0604

Currently if I have a preference page on which I want to create commands dynamically and assign bindings to them there would be problems if the Keys preference page has been opened. The Keys preference page will always get persisted after mine and this would cause my changes to be lost. On my page I always reload all bindings before persisting so it wouldn't be a problem if it gets saved last. I think the Keys preference page should reload the bindings every time it's shown and also before persisting.

Reproducible: Always

Steps to Reproduce:
1. Create another preference page on which commands can be created and bindings can be assigned to them.
2. Run a new instance of Eclipse with this preference page and open the page and the Keys preference page in the same preference dialog.
3. Make some changes in the new page and click OK.

Result: The changes will be lost.

Comment 1 Paul Webster

2012-01-04 07:30:31 EST

The keys preference page was designed to modify the entire set of keybindings or to be replaced completely by another page.

http://wiki.eclipse.org/Platform_UI/How_to_Contribute

It's implemented by org.eclipse.ui.internal.keys.NewKeysPreferencePage

PW

Comment 2 George Dinkov

2012-01-04 07:41:59 EST

Hi Paul,

I'm aware of this. But I think it would be useful to have a way to assign bindings from other pages. In my case I want to be able to create commands dynamically on a preference page and assign bindings to them without getting messed up if I open the Keys preference page before pressing OK.

Regards,
George

Comment 3 Lars Vogel

2019-11-14 03:11:20 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.