Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367813

Summary:	1387 (!) warnings in official build
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Paul Webster <pwebster>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	dean.t.roberts, pwebster, remy.suen
Version:	3.8
Target Milestone:	3.8 M5
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dani Megert

2012-01-04 03:20:07 EST

I20120103-0800 and N20120103-2000.

1387 (!) warnings in official build:

http://download.eclipse.org/eclipse/downloads/drops/I20120103-0800/compilelogs/plugins/org.eclipse.ui.tests_3.7.0.v20111221-1925/uitests.jar.bin.html

Comment 1 Remy Suen

2012-01-04 08:05:08 EST

We changed the BREE to 1.5 in 412bb792f91ba461ddb4451860a72ff58cf8a279.

Comment 2 Dani Megert

2012-01-04 09:38:11 EST

(In reply to comment #1)
> We changed the BREE to 1.5 in 412bb792f91ba461ddb4451860a72ff58cf8a279.

The corresponding bug is bug 351851.

Was it necessary to switch to 1.5? Why?

Comment 3 Dani Megert

2012-01-04 09:41:21 EST

If 1.5 is really needed, I guess we won't go and fix all the warnings. In that case we can add the following line to the 'build.properties':

javacWarnings.javauitests.jar=-deadCode,-raw,-unchecked

and set the corresponding project specific settings to 'Ignore'.

Comment 4 Remy Suen

2012-01-04 09:41:56 EST

(In reply to comment #2)
> Was it necessary to switch to 1.5? Why?

Since the bundle itself has been forked. I would be inclined to say no. At least, certainly not from the view point of the bundle in the R3_development branch.

Comment 5 Dani Megert

2012-01-04 09:42:53 EST

> javacWarnings.javauitests.jar=-deadCode,-raw,-unchecked

Copy & paste bug. This should be:

javacWarnings.uitests.jar=-deadCode,-raw,-unchecked

Comment 6 Paul Webster

2012-01-04 10:04:40 EST

(In reply to comment #4)
> Since the bundle itself has been forked. I would be inclined to say no. At
> least, certainly not from the view point of the bundle in the R3_development
> branch.

We had incoming test contributions for 3.8 that were written in 1.5, and I don't see a reason to disallow it in the test bundle.

I like the idea of adding javacWarnings.uitests.jar=-raw,-unchecked

PW

Comment 7 Paul Webster

2012-01-04 13:51:41 EST

Released into R3_development and master

PW

Comment 8 Dani Megert

2012-01-05 04:57:24 EST

There are 3 left which can probably be manually fixed:

http://download.eclipse.org/eclipse/downloads/drops/N20120104-2000/compilelogs/plugins/org.eclipse.ui.tests_3.7.0.N20120104-2000/uitests.jar.bin.html

Comment 9 Paul Webster

2012-01-05 11:16:45 EST

I've fixed the 3, and released it to both R3_development and master.  Thanks Dani.

PW

Comment 10 Dani Megert

2012-01-06 02:26:58 EST

Verified in N20120105-2000.

Comment 11 Remy Suen

2012-01-06 08:47:55 EST

(In reply to comment #9)
> I've fixed the 3, and released it to both R3_development and master.

The change broke two tests in N20120105-2000. Will push a fix in a bit.

Comment 12 Remy Suen

2012-01-06 08:52:15 EST

(In reply to comment #11)
> Will push a fix in a bit.

Fix pushed to master and R3_development.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3c15aed9c77e3b082619a4ef9fcdcef071263a5f
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R3_development&id=abf2b2073f5ed487612c9f2007e8d062bb1b0aa5

Comment 13 Paul Webster

2012-01-06 09:03:41 EST

Sorry about that, I picked option 2 and should have picked option 1.

PW

Comment 14 Paul Webster

2012-01-24 12:42:28 EST

In http://download.eclipse.org/eclipse/downloads/drops/I20120123-1300/testResults.php

PW