Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367808

Summary:

Cleanup new warnings for missing @Override for Java 6

Product:

[Tools] CDT

Reporter:

Marc Khouzam <marc.khouzam>

Component:

cdt-debug-dsf

Assignee:

Marc Khouzam <marc.khouzam>

Status:

RESOLVED FIXED

QA Contact:

Pawel Piech <pawel.1.piech>

Severity:

normal

Priority:

CC:

cdtdoug

Version:

8.0

Target Milestone:

8.1.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch for dsf and dsf.ui	marc.khouzam: iplog-

Description Marc Khouzam

2012-01-03 22:03:07 EST

Java 6 shows a warning of there is no @Override tag on a method that implements a method of an interface.  Now that we require Java 6 for the DSF plugins, we have a bunch of those warnings.

I will post a patch to add the missing @Override.

Comment 1 Marc Khouzam

2012-01-03 23:01:26 EST

Created attachment 208978 [details]
Patch for dsf and dsf.ui

Here is the patch.  I created with 0 lines of context to make it shorter as the patch was totally mechanical.

Comment 2 Marc Khouzam

2012-01-03 23:05:53 EST

I have committed the patch to master.

Pawel, I won't ask for an official review because it is a painfully boring review.  However, I did the fixes almost entirely using quick-fix shortcuts, so I feel it is pretty safe.

I also ran the DSF-GDB JUnit tests with GDB 7.3 and everything passed.

The commit is 463d52d01b28bac1dad93494d13a8e94b242c952, in case one wants to create a patch with more lines of context.

Comment 3 Marc Khouzam

2012-01-03 23:08:19 EST

BTW, this removes 1007 warnings