Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367802

Summary:

EAR project can be named after an existing project (no validation)

Product:

[WebTools] WTP Java EE Tools

Reporter:

Galileo Perez <galileo>

Component:

jst.j2ee

Assignee:

Galileo Perez <galileo>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

shr31223

Version:

3.3.1

Flags:

galileo: pmc_approved? (david_williams)
galileo: pmc_approved? (raghunathan.srinivasan)
galileo: pmc_approved? (naci.dai)
galileo: pmc_approved? (deboer)
galileo: pmc_approved? (neil.hauge)
galileo: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
cbridgha: review+

Target Milestone:

3.3.2

Hardware:

OS:

Windows XP

Whiteboard:

PMC_Approved

Attachments:

Description	Flags
Validates the name of the EAR project against the projects in the workspace	shr31223: iplog+, galileo: review?
patch to remove the commented code.	none
Test case for the current bug	none
Remove commented code	none
Update min version	none
Update plugin versions (3.3.2)	none
Update plugin versions (3.4)	none

Description Galileo Perez

2012-01-03 17:12:05 EST

Build Identifier: 20110511033327

The name provided to an EAR project is not validated against the existent projects in the workspace that are not EAR Projects.



Reproducible: Always

Steps to Reproduce:
1) Launch the Dynamic Web Project wizard and create a project named 'd' with an ear named 'dEAR'.  Hit finish so it is created
2) Launch the Dynamic Web Project wizard again and name the project 'dd' but change the ear project name to 'd'.  Notice there is no validation error to warn me that a project already exists with that name.

Comment 1 Galileo Perez

2012-01-10 09:48:38 EST

Created attachment 209263 [details]
Validates the name of the EAR project against the projects in the workspace

The patch validates the name of the EAR project against all the non ear projects in the workspace.

Comment 2 Chuck Bridgham

2012-01-11 09:10:11 EST

approved

Comment 3 Galileo Perez

2012-01-11 13:01:39 EST

Created attachment 209331 [details]
patch to remove the commented code.

This patch removes the commented code and replaces the method used on the last patch with the original one.

Comment 4 Galileo Perez

2012-01-11 13:08:33 EST

Second patch should be applied just after the first one, it's not invalidating the previous one.

Comment 5 Galileo Perez

2012-01-11 15:27:46 EST

Created attachment 209340 [details]
Test case for the current bug

This is just a test case for the current bug

Comment 6 Galileo Perez

2012-01-11 15:28:29 EST

PMC Review requested due to UI change
    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
The defect requires a new message to be incorporated into the current bucket of messages. 
    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
     Users can verify the names of the EAR projects by themselves but still insufficient when the workspace has a lot of projects

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
     The fix was tested by the programmer, manually executing the cases when the defect appears.  Not Junit Tests been added. 

    * Give a brief technical overview. Who has reviewed this fix? 
Had a peer review by a team member also WTP commiter, and the QA contact has done a review.

    * What is the risk associated with this fix? 
EJB projects and Dynamic Web projects not to be added into EAR projects when creating from the EJB Project Wizard or Dynamic Web Project wizard

Comment 7 Chuck Bridgham

2012-01-11 16:49:25 EST

This is a safe change - approved

Comment 8 Roberto Sanchez Herrera

2012-01-16 17:02:11 EST

Created attachment 209599 [details]
Remove commented code

The second patch cannot be applied over the first one. I tweaked a little bit the patch so it can be applied.

Comment 9 Roberto Sanchez Herrera

2012-01-16 17:10:00 EST

Code committed to R3_3_maintenance and HEAD for WTP 3.3.2 and 3.4. Resolving defect.

Comment 10 Roberto Sanchez Herrera

2012-01-17 10:54:59 EST

Created attachment 209624 [details]
Update min version

After more review of this patch, I see the min version for plugin org.eclipse.wst.common.frameworks needs to be updated in org.eclipse.jst.j2ee, because org.eclipse.jst.j2ee is using new constants from org.eclipse.wst.common.frameworks. Attaching the patch for this.

Comment 11 Roberto Sanchez Herrera

2012-01-17 11:00:14 EST

Patch for updating min version is committed to R3_3_maintenance and HEAD for WTP 3.3.2 and 3.4.

Comment 12 Roberto Sanchez Herrera

2012-01-18 21:54:48 EST

Created attachment 209713 [details]
Update plugin versions (3.3.2)

This patch does one more update to plugin versions. This patch is for WTP 3.3.2, and can be applied on top of the other patches.

Comment 13 Roberto Sanchez Herrera

2012-01-18 21:56:11 EST

Created attachment 209714 [details]
Update plugin versions (3.4)

This patch does one more update to plugin versions. It is for 3.4, and can be applied on top of the other patches.

Comment 14 Roberto Sanchez Herrera

2012-01-18 22:01:30 EST

Last two patches committed to their appropriate branch for WTP 3.3.2 and 3.4.