Bugzilla – Full Text Bug Listing
| Summary: | user login status popup should not replace user menu | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | antonm, john.arthorne, ken_walker, libingw, malgorzata.tomczyk, mamacdon, Szymon.Brandys |
| Version: | 0.3 | Flags: | malgorzata.tomczyk:
review?
(susan) |
| Target Milestone: | 0.4 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 368870 | ||
|
Description
Susan McCourt
the temporary "operations" thing is now in the footer. So I suggest the following: Username <twistie> ----------- Profile Settings Sign Out Help - I think the login status that shows in the hover today (what plugin you are logged into and since when) has always been an implementation detail that doesn't deserve such an "up front" place. What if we put it in a "login status" pane on the profile page? - I think that help could be moved from a main link to this menu - People are used to looking for settings in a user menu, so I don't see that they need to have their own visible link in the primary nav. cc'ing others for opinion. If no one disagrees I can do this as part of all the common header/footer cleanup (but may need Gosia's help to move the status stuff to the profile page) (In reply to comment #1) > If no one disagrees I can do this as part of all the common header/footer > cleanup (but may need Gosia's help to move the status stuff to the profile > page) actually the "logged in since" is already there, so it's just putting the list of authenticated plugins on the profile somewhere. (In reply to comment #0) > Some sites use the username as a link to the profile (amazon, github) and then > have top level buttons for the other things. > I don't think the user cares what plugin is contributing to that popup anyway. The info in the header is not what plug-in contributes to the popup, but what server we are logged in to. If you have multiple filesystems plugged in to Orion, you will see something like this: Server1 [Profile][Sign Out] x logged in since ... Server2 [Profile][Sign Out] y logged in since ... Most of the time we have only one auth plugin registered. Then I would expect to see: AUser [v] |_ Preferences |_ Operations |_ Sign Out |_ Help Clicking on "AUser" would open the profile page. For many auth plug-in registered, I would like to see: Profiles [v] |_ Preferences |_ Operations |_ Help Clicking on "Profiles" would open a popup or a page that allows to visit profiles and sign out from servers. Alerts like "Need to log in to something" would have a separate presentation. Maybe still a popup but different than the one for managing profiles. It would just ask to login to some server, not show a list of all registered auth plug-ins. minor point is we don't need "Operations" because it's in the footer now. I named it "Server Operations" but if you prefer a better name it's easy to change. I felt like "Operations" was not obvious to a newbie what it might mean. Maybe "Background Operations"? marking M2 as I hope to resolve where "operations" and "settings" go as part of the header/footer. It may slip to the RC's though. see also bug 349602 Susan, if you are very busy (and I think you are) than I can take it over from you. (In reply to comment #7) > Susan, if you are very busy (and I think you are) than I can take it over from > you. THANKS, Gosia! Yes, please do. There are a few help menu items I'd like to see here as part of bug 349602 (but I kept that bug because it also involves general keybinding checking). I imagine something like this: User [V] Settings (link to settings page) Operations Sign out --------------------- (separator) Help-> Documentation (the link fr) Keyboard Help (the key assist panel command) About Orion (href to the about.html) It sounds like you and Szymon know what to do re: Profiles. I was thinking profile was in the menu but I guess it's the difference between clicking "User" and clicking "menu". Does not matter to me. Note that if we are going to use an empty menu rather than the user name being the label for the menu, we have to ensure there is some accessible explanatory text on the menu itself. Please see bug 368870 (which I've just assigned to you.) Then remove from the banner (now in commonHTMLFragments.js) - help icon Remove from footer - Server Operations In org.eclipse.orion.client.core/web/plugins/pageLinksPlugin.html - remove the "settings link" (In reply to comment #8) > About Orion (href to the about.html) This is one thing I don't know, where is the about.html page? I know we have an Orion page on wiki is this what you mean? I pushed most of the changes, Susan, how do you like it now? If it's ok now adding the link to about.html (when I know what it is) will be the last thing to do here. Hi, this looks great. The about link is http://orion.eclipse.org/help/about.html In playing with it, I have one more request (sorry!) Grouping the help items doesn't play well, does it? You get that right arrow but of course the whole menu is on the right so you end up getting the submenu on the left. I didn't think about that ahead of time. So could we flatten that group and just have ------------ (separator) Help (which is the thing I previously called "Documentation") Keyboard Help About Orion Thanks again. I will worry about the hover (and possibly changing the dropdown icon) as part of my ongoing work with styling.... Just trying this, when I go to the settings page, the triangle beside the username doesn't seem to be there? (In reply to comment #12) > Just trying this, when I go to the settings page, the triangle beside the > username doesn't seem to be there? I noticed it as well, this is only at the settings page. Maybe there's some css missing or overriding there? (In reply to comment #13) > (In reply to comment #12) > > Just trying this, when I go to the settings page, the triangle beside the > > username doesn't seem to be there? > I noticed it as well, this is only at the settings page. Maybe there's some css > missing or overriding there? I opened bug 371104. I seem to recall a dojo override of the menu background for the settings page. This should be qualified so that the override is not pervasive. OK, changes from comment #11 are applied, so I suppose this is all what's to do on this bug. |