Bugzilla – Full Text Bug Listing
| Summary: | should HTML content assist live in the editor plugin | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Susan McCourt <susan> |
| Component: | Client | Assignee: | John Arthorne <john.arthorne> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | eclipse.felipe, john.arthorne, mamacdon, mihai.sucan, Silenio_Quarti, susan |
| Version: | 0.4 | ||
| Target Milestone: | 0.4 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Susan McCourt
To clarify the current state, the HTML content assist *is* being provided by the same plugin as the JS/CSS stuff (webEditingPlugin.html). The different is that the JS code for it is located in org.eclipse.orion.client.core rather than org.eclipse.client.editor. I don't know how important this is because I suspect people aren't consuming our stuff at the granularity of our OSGi bundles. I do agree it seems inconsistent and I'm open to moving it wherever. there was a time when we were trying to put anything that the "minimal editor example" needed in the editor bundle. We were also anticipating that consumers like FF/scratchpad would never want anything from core, but might want various content assist, etc. However, I think they are consuming at a lower level (textview) anyway. But I don't follow this as closely anymore, so I defer to Felipe/Silenio, Mihai, Mark... The content assist stuff makes sense (for us, Firefox) to be available in org.eclipse.client.editor. The client.core code seems to be out of scope for our integration. We are currently only using the client.editor TextView, but we might expand our usage of Orion to include the additional features of client.editor (the Orion editor). This will probably happen once we need to add content assist features. I think that keeping the HTML content assist in the editor bundle is better than moving it to core. Personally think the core bundle should have less stuff in it than it has now, see: https://bugs.eclipse.org/bugs/show_bug.cgi?id=362808#c1 I have moved it to the editor plugin folder: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0f7eff5d831c2f805d103e342746a9968384a421 Forgot to mark fixed. |