Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367779

Summary:	Embedded editor example is not working
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Editor	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	eclipse.felipe, malgorzata.tomczyk, susan
Version:	0.4
Target Milestone:	0.4 M2
Hardware:	PC
OS:	All
Whiteboard:

Description Mark Macdonald

2012-01-03 12:24:09 EST

Orion 2012-02-02-2230

1. Start Orion on localhost
2. Go to http://localhost:8080/examples/editor/embeddededitor.html
3. There's a JS error. The editor doesn't load.

Uncaught TypeError: Object require,orion/textview/textView,orion/textview/keyBinding,examples/textview/textStyler,orion/editor/textMateStyler,orion/editor/htmlGrammar,orion/editor/editor,orion/editor/editorFeatures,orion/editor/contentAssist,orion/editor/jsContentAssist,orion/editor/cssContentAssist has no method 'split'

Comment 1 Susan McCourt

2012-01-03 12:40:12 EST

Mark, do you want to take this one since you are most active on the editor/client side?  (Or is someone working on CSS content assist?)

Comment 2 Felipe Heidrich

2012-01-03 12:47:08 EST

the changes of http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6ba402f52bc6e143a94dd1a80ee3b77b8c59d0a9 got lost at some point

besides, contentAssist.addProvider apparently got renamed to setProvider too

Comment 3 Mark Macdonald

2012-01-03 12:52:45 EST

(In reply to comment #2)
> besides, contentAssist.addProvider apparently got renamed to setProvider too

This one is my fault, I'll fix it.

Comment 4 Felipe Heidrich

2012-01-03 12:57:34 EST

I put back the change to embeddededitor.html

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=31e87ce55d71312e8c0ac73a535d7d5a155ea337

for some reason it was removed at this commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6243921f2ef1567acb111e4000ccc526f5309ba

Malgorzata, was the change to minimaleditor.html and embeddededitor.html accidental ?

Comment 5 Mark Macdonald

2012-01-03 13:16:21 EST

Fixed up the content assist
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1f6b1ea14ddb465d0a05267afa75ad878666c4b7

Comment 6 Malgorzata Janczarska

2012-01-04 04:18:51 EST

(In reply to comment #4)
> I put back the change to embeddededitor.html
> 
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=31e87ce55d71312e8c0ac73a535d7d5a155ea337
> 
> for some reason it was removed at this commit:
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e6243921f2ef1567acb111e4000ccc526f5309ba
> 
> Malgorzata, was the change to minimaleditor.html and embeddededitor.html
> accidental ?

This is a merge commit, so I'm sure it's just an error while merging.
Sorry about that!

Comment 7 Felipe Heidrich

2012-01-04 13:58:47 EST

This is fixed, right ?

Comment 8 Mark Macdonald

2012-01-04 14:18:43 EST

(In reply to comment #7)
> This is fixed, right ?

Yes