Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367749

Summary: Error handling in ProjectSetImporter.importProjectSet is wrong
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: TeamAssignee: Dani Megert <daniel_megert>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, tomasz.zarna
Version: 3.8   
Target Milestone: 3.8 M5   
Hardware: All   
OS: All   
Whiteboard:

Description Dani Megert CLA 2012-01-03 07:18:43 EST
3.8 M4.

The error handling in ProjectSetImporter.importProjectSet needs to be improved: it collects the TeamExceptions but if some other exceptions happen (like an assertion failure) then the TeamExceptions are swallowed i.e. not reported.

Also, CVSProjectSetCapability.addToWorkspace should probably covert the IAE into a TeamException.


Test Case:
1. install 3.8 M4 plus EGit
2. start with new workspace
3. import team project set from attachment 208048 [details]
Comment 1 Dani Megert CLA 2012-01-03 09:19:41 EST
The biggest bug is that referenceStrings is not cleared when an exception happens. As a result, the next provider tries to load project references from the previous one and then fails badly.
Comment 2 Dani Megert CLA 2012-01-03 10:13:05 EST
Fixed in master: 45e2a2fe42c326895aaa0a4323b9650225fa7863