Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367744

Summary:

Verify if the JAVA_HOME is set before build starts

Product:

[Tools] Linux Tools

Reporter:

Krzysztof Daniel <krzysztof.daniel>

Component:

eclipse-build

Assignee:

Krzysztof Daniel <krzysztof.daniel>

Status:

RESOLVED FIXED

QA Contact:

Alexander Kurtakov <akurtakov>

Severity:

enhancement

Priority:

CC:

krzysztof.daniel

Version:

unspecified

Target Milestone:

1.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch proposition	krzysztof.daniel: review-
Patch v2	none
Patch v2 - proper diff	none
Patch v3 - better naming	none
Patch v4 in git format	overholt: iplog+

Description Krzysztof Daniel

2012-01-03 06:32:54 EST

because it will fail otherwise

Comment 1 Krzysztof Daniel

2012-01-03 09:41:20 EST

Created attachment 208937 [details]
Patch proposition

A check if the java home is really set.

Comment 2 Krzysztof Daniel

2012-01-03 11:13:58 EST

Created attachment 208942 [details]
Patch v2

Comment 3 Krzysztof Daniel

2012-01-03 11:17:01 EST

Created attachment 208943 [details]
Patch v2 - proper diff

Comment 4 Andrew Overholt

2012-01-03 11:17:21 EST

This looks good to me.  Would it be possible to provide a git-formatted patch so that you'll remain as the author?  Thanks!

Comment 5 Krzysztof Daniel

2012-01-03 11:18:25 EST

Created attachment 208944 [details]
Patch v3 - better naming

Comment 6 Krzysztof Daniel

2012-01-03 11:31:37 EST

Created attachment 208945 [details]
Patch v4 in git format

Comment 7 Andrew Overholt

2012-01-03 16:24:22 EST

Thanks for the patch.  Pushed in 0c3a5d1:  http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.eclipse-build.git/commit/?id=0c3a5d17d9aeeadf57141aeaba3b65d1ff533584 (not working for some reason).

Comment 8 Andrew Overholt

2012-01-04 14:09:08 EST

Setting target milestone.