Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367713

Summary: FontConfigReaderTest is encoding dependent
Product: z_Archived Reporter: Krzysztof Kazmierczyk <kazm>
Component: BIRTAssignee: Birt-ReportEngine-inbox <Birt-ReportEngine-inbox>
Status: RESOLVED FIXED QA Contact: Xiaoying Gu <bluesoldier>
Severity: normal    
Priority: P3 CC: bluesoldier, hustlg, kkazmierczyk+eclipse
Version: unspecified   
Target Milestone: 4.2.0 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch none

Description Krzysztof Kazmierczyk CLA 2012-01-02 11:24:57 EST 
Build Identifier: I20110613-1736

When you have workspace encoding different than utf-8 and checkout org.eclipse.birt.report.engine.tests project from CVS you have the following error message: 
Invalid character constant in FontConfigReaderTest.java at line 63

It is a defect - if a project depends on specific encoding, it should be set in project preferences.

Another but safer fix is to replace character from line 63 with \u624b symbol which is hex value of that character. The second option is simpler and it is lower chance to introduce regression.

See also FontConfigReaderTest.java at line 49 where the same character is used.

Reproducible: Always

Steps to Reproduce:
1. In Windows->Preferences->General->Workspace set Text file encoding to iso-8859-1
2. Checkout FontConfigReaderTest from CVS repository
You will have Error in FontConfigReaderTest.java at line 63
Comment 1 Krzysztof Kazmierczyk CLA 2012-01-02 11:31:56 EST 
Created attachment 208920 [details]
Patch
Comment 2 Krzysztof Kazmierczyk CLA 2012-01-05 07:46:23 EST 
The patch applies for both CVS and git repository
Comment 4 Krzysztof Kazmierczyk CLA 2012-04-20 04:04:10 EDT 
Xiaoying, this has been fixed in line 49 but the line 63 still contains the issue. Could you review it again. please?
Comment 5 Krzysztof Kazmierczyk CLA 2012-04-20 04:04:39 EDT 
reopening
Comment 6 Xiaoying Gu CLA 2012-04-20 05:00:12 EDT 
(In reply to comment #4)
> Xiaoying, this has been fixed in line 49 but the line 63 still contains the
> issue. Could you review it again. please?

Sorry for the confusion.
Yes the file in master branch is still not correct. We will update in the next milestone.
Comment 7 Xiaoying Gu CLA 2012-05-31 01:22:26 EDT 
Set as fixed.