Bugzilla – Full Text Bug Listing
| Summary: | Restore "use traditional style tabs" in Classis Theme | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Hasan Ceylan <hceylan> |
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | 1983-01-06, bruno.do.medeiros, gheorghe, J.F.Lanting, pwebster, remy.suen, rs, Sjon, tanmatra |
| Version: | 4.1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | stalebug | ||
| Attachments: | |||
|
Description
Hasan Ceylan
I think you may be able to workaround the problem by editing the classic CSS file. Yes I should. But I can wait if that is to be implemented. will it? (In reply to comment #2) > Yes I should. But I can wait if that is to be implemented. will it? Not sure what exactly you're asking here. But this is already modifiable in the CSS file. > - simple: false; > + simple: true; Eclipse in entirety is already modifiable, but I certainly expect its features to persist across as new versions come along. I do appreciate that some features may be dropped in favor of new and better ones. The "traditional tabs" is currently an officially supported feature of eclipse. therefore here I am NOT asking you to create a custom theme for me. I am simply trying to understand if the "traditional tabs" will be supported in eclipse 4.0 or not. If it IS to be supported, I certainly want to avoid the double work, not to mention trying to getting used the (IMHO) uglier curly tabs. Hope this makes it clear... (In reply to comment #4) > The "traditional tabs" is currently an officially supported feature of eclipse. > therefore here I am NOT asking you to create a custom theme for me. I am simply > trying to understand if the "traditional tabs" will be supported in eclipse 4.0 > or not. You can use the Classic themes and follow the CSS outlined in comment 3. Unless your problem is that the new theme have rounded corners in their tabs. I think what Hasan is asking for is that one is somehow able to enable traditional style tabs using the Eclipse UI alone, that is, without having to edit the CSS files outside of Eclipse. So we could have a checkbox in the Eclipse UI Preferences for traditional tabs, or have another theme identical to Classic, except in the tabs CSS option (I prefer the former, but the later might be much more straightforward to implement). IMO it's not that important since the workaround works fine, but it would still be nice to have. (In reply to comment #6) > I think what Hasan is asking for is that one is somehow able to enable > traditional style tabs using the Eclipse UI alone, that is, without having to > edit the CSS files outside of Eclipse. While I'm not sure about our plans w.r.t. this bug, one of the 4.2 tools that we plan on supplying augments the General>Appearance page with an embedded CSS editor, that can then be used to edit the CSS used by your eclipse. Re-apply and then restart. It's already available at http://download.eclipse.org/e4/updates/0.12-I-builds (it needs XText from Juno, http://download.eclipse.org/releases/juno ) PW Created attachment 210816 [details]
Visual Description
(In reply to comment #8) > Created attachment 210816 [details] > Visual Description I guess it's safe to say you want a preference then. Though I don't think we'd be giving this a high priority. (In reply to comment #5) > (In reply to comment #4) > > The "traditional tabs" is currently an officially supported feature of eclipse. > > therefore here I am NOT asking you to create a custom theme for me. I am simply > > trying to understand if the "traditional tabs" will be supported in eclipse 4.0 > > or not. > > You can use the Classic themes and follow the CSS outlined in comment 3. > > Unless your problem is that the new theme have rounded corners in their tabs. Remy, I can write Eclipse from scratch, that does not mean I should nor it is a rational. Eclipse is known with its perfect compatibility over the years, that's why we have been on version 3.x since eclipse 3.0's debut in 2004. I still can use plugins that were last released long time ago and not touched, i.e. Eclipse Metrics. I am very stingy about the working domain in eclipse and that's what I have been teaching my teams over the years. Round corners take more space and i.e. makes the toolbar wrap to the line below for the folder if Package Explorer shares it with another view. And not everyone in my team has 1920x1200 displays. So I am not trying to be annoying but in exchange I wish my counterpart to take time to study the need and then answer, as I am taking my time to report / help / contribute to improve Eclipse. Having said that, again I do understand that Eclipse 4.x is not Eclipse 3.x and in major versions, some features do become incompatible. Therefore I am not asking whether I could or how I could do things. Rather What I am asking is will you include this very simple feature or not. And that does not mean you must / should... Hope now I make myself clear. Created attachment 210818 [details] Screenshot depicting the state in question. (In reply to comment #10) > So I am not trying to be annoying but in exchange I wish my counterpart to take > time to study the need and then answer, as I am taking my time to report / help > / contribute to improve Eclipse. Hasan, the visual presentation of what (I think) you want, an Eclipse 3.x look with simple tabs, is already possible in Eclipse 4. Please see my attachment to this comment. As I have previously mentioned, what you want is configurable through CSS. It seems to me that manually editing the CSS file is not to your liking and I can understand that. It is most certainly non-obvious to the average Eclipse user that's coming from 3.x to have to edit a random CSS file located in the eclipse/ folder. > Therefore I am not > asking whether I could or how I could do things. Rather What I am asking is > will you include this very simple feature or not. Unfortunately, as I have previously stated in comment 9, adding a preference back to the preference page is not likely to be a high priority for us. This is because the preference would simply be doing the same thing as what editing the CSS file would achieve. > Hope now I make myself clear. While I would like to think that I understand what you are asking for in this bug report, I honestly cannot say. If the attached image is not what you actually wanted, then I can safely say that I have misinterpreted your screenshot and the comments you have put on this bug. OK, this becoming rather ridiculous. (In reply to comment #11) > Created attachment 210818 [details] > Screenshot depicting the state in question. > The original bug report is against 4.1, yet you reply this feature is *already* available, showing me screenshot from 4.2 M5 released ~10 days ago, assuming I should know all the changes in the 4.2 milestone releases. > (In reply to comment #10) > > So I am not trying to be annoying but in exchange I wish my counterpart to take > > time to study the need and then answer, as I am taking my time to report / help > > / contribute to improve Eclipse. > > Hasan, the visual presentation of what (I think) you want, an Eclipse 3.x look > with simple tabs, is already possible in Eclipse 4. Please see my attachment to > this comment. I am not talking with the terms that I invent, rather I make attributions to Official Eclipse UI Terms. Based on that, even after the screenshot I sent if still "(I thought)", then I would first study Eclipse UI then I engage users over bug reports. > > As I have previously mentioned, what you want is configurable through CSS. It > seems to me that manually editing the CSS file is not to your liking and I can > understand that. It is most certainly non-obvious to the average Eclipse user > that's coming from 3.x to have to edit a random CSS file located in the > eclipse/ folder. I have manually edited CSS way more then you think and I consider myself expert on that. Yet you still do not get my point. My point once again, if eclipse 4.2 will eventually support 3.x classic theme with traditional style tabs, then why I should do it, maintain it and distribute it to my team? On the other hand FYI, the the default theme with traditional style tabs is what you get when you create an RCP, I think you get that with that missing, RCP applications implicitly change their behavior. > > > Therefore I am not > > asking whether I could or how I could do things. Rather What I am asking is > > will you include this very simple feature or not. > > Unfortunately, as I have previously stated in comment 9, adding a preference > back to the preference page is not likely to be a high priority for us. This is > because the preference would simply be doing the same thing as what editing the > CSS file would achieve. > I do not know what to say to this comment... > > Hope now I make myself clear. > > While I would like to think that I understand what you are asking for in this > bug report, I honestly cannot say. > Based on "you would like to think that you understand", why don't you instruct me how I should state my point in English, obviously for a non native English speaker that is the limit. So next time I interact with you, I would first discuss the issue over IRC then enter the bug report, not to mention this will improve my English. > If the attached image is not what you actually wanted, then I can safely say > that I have misinterpreted your screenshot and the comments you have put on > this bug. We both know the attachment you posted is perfectly what I am asking, so stop playing with the words. On the other hand there is still a point that you *misinterpret*, I am not wanting since comment #2, rather just asking if this feature will restored. Last but definitely not the least, the "Average Eclipse User" you are referring to - has been using Eclipse since 2.x, - has contributed to projects including (may be not limited to) SWT, RCP, OSGI, EMF, Teneo, XWT, CDO, XText, Xpand, - developed an Eclipse EMF Builder, - put together 4 RCP / RAP based large scale enterprise applications of which one was the largest Eclipse RT implementation to its time, - proposed will-be Eclipse RT before the project was created. [1] Regards, Hasan Ceylan [1] http://www.eclipse.org/forums/index.php/mv/msg/103827/317044/#msg_317044 Created attachment 210825 [details]
Screenshot depicting the state in question on Linux / GTK
By the way I (re)experimented with 4.1 and 4.2 M5. Nothing new on the issue with both versions.
See the new attachment, either I am missing something or I guess the feature exists only on Windows / does not exist on Linux GTK, as you use Windows as the choice of OS where as I use Linux.
I guess the round up from this bug: 1) we are providing a few pre-canned themes based on CSS for 4.x. 2) we will try and put as many of the old appearance preferences that are formatting related as attributes in the CSS as we can. 3) You can either copy out the CSS and edit it with the tool of your choice or install the E4 Tools>E4 CSS editor from the http://download.eclipse.org/e4/updates/0.12-I-builds (based on XText from Juno). PW > I guess the round up from this bug:
>
> 1) we are providing a few pre-canned themes based on CSS for 4.x.
>
> 2) we will try and put as many of the old appearance preferences that are
> formatting related as attributes in the CSS as we can.
>
> 3) You can either copy out the CSS and edit it with the tool of your choice or
> install the E4 Tools>E4 CSS editor from the
> http://download.eclipse.org/e4/updates/0.12-I-builds (based on XText from
> Juno).
>
> PW
Thank you Paul, it is always good to see solution oriented minds in Open Source Projects, especially under the roof of Eclipse.
I just installed 4.2.0, and could not find the 'Use traditional style tabs' checkbox. Where is 'the' css file that is described in this bug located? I have looked in .metadata, ~/.eclipse and /usr/share/eclipse, but I couldn't find any CSS file that includes the mentioned 'simple: false;' statement? (In reply to comment #16) > I just installed 4.2.0, and could not find the 'Use traditional style tabs' > checkbox. Where is 'the' css file that is described in this bug located? > > I have looked in .metadata, ~/.eclipse and /usr/share/eclipse, but I couldn't > find any CSS file that includes the mentioned 'simple: false;' statement? Check out http://wiki.eclipse.org/Eclipse4/CSS to edit the CSS within eclipse, and an example with "swt-simple: true" PW Ah, after finding out that http://download.eclipse.org/e4/updates/0.12 is an update site (which, obviously... generates a 404 when visiting it from a browser) I found the editor (which doesn't work but I'll post another bug for that). Thanks! (In reply to comment #18) > Ah, after finding out that http://download.eclipse.org/e4/updates/0.12 is an > update site (which, obviously... generates a 404 when visiting it from a > browser) Thanks, I updated the wiki to make it more obvious. PW But how would I apply this CSS workaround on a site-wide install where the program folder is write-protected? Can I supply this file in a user-defined location? I've just tried the CSS editor and all it's giving me is "Save could not be completed. Try File > Save As... if the problem persists." (In reply to comment #20) > But how would I apply this CSS workaround on a site-wide install where the > program folder is write-protected? Can I supply this file in a user-defined > location? I've just tried the CSS editor and all it's giving me is "Save > could not be completed. Try File > Save As... if the problem persists." When you try and edit your CSS in the Preferences>General>Appearance page? If so, a workaround would be to manually create a $HOME/.e4css directory and copy the appropriate css file there, like e4_default_gtk.css in my case. Then modify that and restart eclipse. PW Created attachment 220159 [details]
Behavior of the CSS editor if program folder is readonly
(In reply to comment #22) > Created attachment 220159 [details] > Behavior of the CSS editor if program folder is readonly Could you please open a new bug for that? On my system the css editor makes a copy of that file before trying to edit it and save it (it doesn't update the plugins directory version). PW (In reply to comment #23) > (In reply to comment #22) > > Created attachment 220159 [details] > > Behavior of the CSS editor if program folder is readonly > > Could you please open a new bug for that? On my system the css editor makes > a copy of that file before trying to edit it and save it (it doesn't update > the plugins directory version). Ah, I tested some more, and got it to work: I've found that only when I use Ctrl+S in that CSS editor, the error message seems to appear; when I use 'Apply' (the button) however it works, and the file in $HOME that you mentioned is there; it still shows the old CSS file in the CSS editor pane but after a restart the new settings have taken effect; the preferences page from that point on shows an error "Resource '/.e4css/e4_classic_winxp.css' does not exist", but all in all it works, nice. Another thing: I used to have white-on-black for editor tabs. Is that still possible? I only see properties for the background color... -- I also notice that the old color properties for editor folders in Preferences > General > Appearance > Colors and Fonts > View and Editor Folders are still there and even show a preview (that doesn't match the actual appearance from the CSS). How do these relate to the CSS properties? (In reply to comment #24) > Another thing: I used to have white-on-black for editor tabs. Is that still > possible? I only see properties for the background color... -- I also notice > that the old color properties for editor folders in Preferences > General > > Appearance > Colors and Fonts > View and Editor Folders are still there and > even show a preview (that doesn't match the actual appearance from the CSS). > How do these relate to the CSS properties? Any of the properties (like tab colour) that was surfaced in the CSS currently has its preference value ignored. We hope to fix that in 4.3 (Kepler) so that either the pref reflects the CSS value, or modifying the pref can update the CSS. PW Hello, I just installed 4.3M6 on my MacBook and it seems that I can not change the color of the Editor tabs in: Preferences>General>Appearance>Colors and Fonts [] Active part ... although the Preview (Lorem Ipsum Dolor sit) shows what I want. Is that problem related to the above discussion and the promise to have it fixed in 4.3 or should I submit a new bug? ;JOOP! (In reply to comment #26) > Hello, > I just installed 4.3M6 on my MacBook and it seems that I can not change > the color of the Editor tabs in: > Preferences>General>Appearance>Colors and Fonts [] Active part ... > although the Preview (Lorem Ipsum Dolor sit) shows what I want. That's bug 355946, which will cover having prefs and CSS work better together > > Is that problem related to the above discussion and the promise to have > it fixed in 4.3 or should I submit a new bug? This won't be fixed in 4.3 PW Thanks for the info. ;JOOP! This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. If the bug is still relevant, please remove the stalebug whiteboard tag. As far as I've seen the preference is still not there, neither is the CSS editor, but both the Light as well as the Dark theme have a tab renderer which doesn't have curvy tabs (at least on my Windows machine) and they are a good configuration-free alternative for me, instead of Classic. Not sure how the original submitter would see this. |