Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367457

Summary:	Switch Massif Charting from BIRT to using SWTChart
Product:	[Tools] Linux Tools	Reporter:	Roland Grunberg <rgrunber>
Component:	Valgrind	Assignee:	Roland Grunberg <rgrunber>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	ebaron, obusatto, overholt
Version:	unspecified
Target Milestone:	1.0
Hardware:	PC
OS:	Linux
Whiteboard:

Description Roland Grunberg

2011-12-22 15:50:56 EST

The Valgrind Massif charting is a great example of taking a really useful command line tool and using various UI elements to present the information in an easy to understand manner.

However the dependency on BIRT for Valgrind seems a bit excessive, when considering it is only used for the Massif charting. I've been working on providing the same functionality using SWTChart (http://www.swtchart.org/). It's a lightweight alternative that uses just SWT and I've been able to duplicate the functionality provided by BIRT.

- The look of the BIRT chart can be reproduced almost identically
- The data point listeners to link to the snapshots/source code can be reproduced by attaching a listener to the chart area itself
- We'd export a chart to PNG as opposed to SVG

This can be viewed here : http://fedorapeople.org/gitweb?p=rgrunber/public_git/org.eclipse.linuxtools.git

The next steps would be to open up a CQ to announce the dependency on org.swtchart and to get that library into Orbit. From there we could probably commit the changes. The deadline for CQs intended for Juno is February 3rd.

Comment 1 Andrew Overholt

2011-12-22 16:37:06 EST

In the interest of full transparency, this was motivated by a consumer (Red Hat) wanting to trim dependencies.

Comment 2 Roland Grunberg

2012-01-30 16:17:53 EST

feature/valgrind/no-birt in org.eclipse.linuxtools git repo is the branch representing these proposed changes. org.swtchart has also been accepted into Orbit.

Comment 3 Andrew Overholt

2012-01-31 10:50:45 EST

When do you intend to move this to master, Roland?

Comment 4 Roland Grunberg

2012-03-01 10:41:17 EST

This work (feature/valgrind/no-birt) has been merged into master.

Comment 5 Otavio Pontes

2012-03-07 11:38:33 EST

Can you rename the org.eclipse.linuxtools.internal.valgrind.massif.birt package?
I think it is better to remove birt from the package name too, because we are not using it anymore.

Comment 6 Roland Grunberg

2012-03-07 12:14:36 EST

I'll be sure to do this as well. Seeing as it's internal, there shouldn't be any issues with this change in non-valgrind plugins.