Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367437

Summary: Project with .js extension name can be opened in Editor
Product: [ECD] Orion Reporter: Ken Walker <ken_walker>
Component: ClientAssignee: Ken Walker <ken_walker>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: mamacdon
Version: 0.4   
Target Milestone: 0.4 M2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Proposed patch to omit directories from open with none

Description Ken Walker CLA 2011-12-22 11:04:16 EST 
In the Navigator choose "New Folder.." in the task area and enter "test.js" as the folder name.

In the Navigator use the popup Actions Menu to select the item Open With -> Orion Editor

The editor opens on the meta data for the project.

True for other types like HTML as well.
Comment 1 Ken Walker CLA 2012-01-03 18:18:44 EST 
Created attachment 208971 [details]
Proposed patch to omit directories from open with
Comment 2 Ken Walker CLA 2012-01-03 18:19:55 EST 
Mark is it possible for you to review this patch?
Comment 3 Ken Walker CLA 2012-01-03 18:28:28 EST 
The patch intends to remove the "open with" submenu for matches which are
directories
Comment 4 Mark Macdonald CLA 2012-01-03 18:34:52 EST 
Patch looks & works OK to me, +1
Comment 5 Ken Walker CLA 2012-01-03 20:42:47 EST 
https://github.com/kenwalker/orion.client/tree/Patch_367437  should have the correct patch.
Comment 6 Mark Macdonald CLA 2012-01-12 10:48:40 EST 
We can mark this fixed now, right? The patch has been pushed:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3a788774655ff310e22d366a4e346116bb86f10d
Comment 7 Ken Walker CLA 2012-01-12 11:15:52 EST 
yes, this is fixed
Comment 8 Ken Walker CLA 2012-01-16 15:00:54 EST 
Apparently I should be adding

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.