Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367290

Summary:	Javadoc of @Execute and @CanExecute are mixed up
Product:	[Eclipse Project] Platform	Reporter:	Missing name <pdeuster>
Component:	Runtime	Assignee:	Paul Webster <pwebster>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	pwebster
Version:	4.2
Target Milestone:	4.2 M5
Hardware:	All
OS:	All
Whiteboard:

Description Missing name

2011-12-21 05:52:22 EST

Build Identifier: 

The Javadoc of @Execute (org.eclipse.e4.core.di.annotations.Execute) is:

> Use this annotation to tag methods that determine if this object's {@link Execute} method can be called. The tagged method must return Boolean value.


The Javadoc of @CanExecute (org.eclipse.e4.core.di.annotations.CanExecute) is:

> Use this annotation to tag methods that need to be executed.


It should be the other way round.

Reproducible: Always

Steps to Reproduce:
1. Open http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/di/annotations/CanExecute.java
2. Open http://dev.eclipse.org/viewcvs/viewvc.cgi/e4/org.eclipse.e4.ui/bundles/org.eclipse.e4.core.di/src/org/eclipse/e4/core/di/annotations/Execute.java
3. Compare
4. Notice Javadoc is mixed up

Comment 1 Paul Webster

2011-12-21 07:27:28 EST

Just as an aside, if you are looking at our source you should be using git now.  See http://wiki.eclipse.org/Platform_UI/How_to_Contribute

I'll fix the javadoc, thanx for finding this.

PW

Comment 2 Paul Webster

2011-12-21 08:32:56 EST

released to master
PW