Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367244

Summary:	Where has IReferenceFinder gone?
Product:	[Modeling] TMF	Reporter:	Ed Willink <ed>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jan, knut.wannheden
Version:	2.2.1
Target Milestone:	---
Hardware:	PC
OS:	Windows Vista
Whiteboard:

Description Ed Willink

2011-12-20 15:29:13 EST

IReferenceFinder was part of the Xtext 2.0 (Indigo) public API.

Since M4 it has vanished (the MDT/OCL Tools build now fails).

Please restore it.

Comment 1 Ed Willink

2011-12-20 15:50:12 EST

Correction: the @SuppressWarnings all makes it appear like public API.

Where has it gone/what is the replacement?

Comment 2 Knut Wannheden

2011-12-20 16:50:31 EST

Hi Ed,

In Git HEAD the IReferenceFinder was just moved (see http://git.eclipse.org/c/tmf/org.eclipse.xtext.git/commit/?id=369599335b14f770814c31acc9274a13bd1442c5) from the package org.eclipse.xtext.ui.editor.findrefs to org.eclipse.xtext.ui.findrefs (still marked as internal). But in all previous release builds it should still more or less be the same API as it was in the 2.0 release.

Comment 3 Jan Koehnlein

2011-12-21 08:17:48 EST

Looks like you don't need API tooling if MDT/OCL depends on you ;-)

I moved the classes/interfaces as I wanted to separate the search UI stuff from the more generic, editor independent find references stuff. Given your feedback and the way the implementation has evolved, I am inclined to move these back...

Comment 4 Ed Willink

2011-12-21 09:14:31 EST

(In reply to comment #3)
> Looks like you don't need API tooling if MDT/OCL depends on you ;-)
I suspect that MDT/OCL is only sensitive to 25% of the potential API.
> 
> I moved the classes/interfaces as I wanted to separate the search UI stuff from
> the more generic, editor independent find references stuff. Given your feedback
> and the way the implementation has evolved, I am inclined to move these back...

No, do what you think is best. I added the reference finder stuff at M7, but I'm not sure that it really worked, you were still evolving. I just never got round to deleting it.

Until Buckminster stops giving ridiculously narrow default version ranges MDT/OCL builds are single train only.

Comment 5 Ed Willink

2011-12-21 09:36:15 EST

(In reply to comment #4)
> > and the way the implementation has evolved, I am inclined to move these back...
> 
> No, do what you think is best.

There might be an API issue for Indigo SR2.

MDT/OCL should not change dependencies from the main Indigo release, so if Xtext provides a changed 'internal' API for e.g. Xtext 2.2.1 SR2 and advertises this as the Indigo SR2 release, a situation could arise whereby MDT/OCL users require the non-SR2 Xtext release. No problem if the restructuring makes it's first appearance in Juno.

Comment 6 Jan Koehnlein

2011-12-21 10:01:37 EST

I give in. Moved the classes back to have peace during my holidays :-)

Comment 7 Ed Willink

2011-12-23 13:58:37 EST

(In reply to comment #6)
> I give in. Moved the classes back to have peace during my holidays :-)

If you're going to move them back please do so.

At the moment we're broken because they've moved. If we correct them we'll be broken again when you move back.

Comment 8 Karsten Thoms

2017-09-19 17:22:56 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 9 Karsten Thoms

2017-09-19 17:34:22 EDT

Closing all bugs that were set to RESOLVED before Neon.0