Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367220

Summary:	parameter collectors for section/pane commands
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Susan McCourt <susan>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, john.arthorne, Szymon.Brandys
Version:	0.3
Target Milestone:	0.4 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:
Bug Blocks:	349328

Description Susan McCourt

2011-12-20 11:54:53 EST

Consider the "new favorite" icon in the favorites section.
We currently don't have a distinctive way to collect parameters from a section.  We probably want a slideout/folddown, etc.
This is even more necessary in the new section pages like the repo page, preferences, etc.

This parameter collector is independent of the global page architecture, so it needs to be implemented in its own file.  We are probably going to have to come up with a shared scheme that maps section heading CSS classes, id's etc. so that the collector can recognize a page section and insert the parameter collection in a well known place.

Comment 1 Susan McCourt

2011-12-20 11:56:29 EST

this also means the command framework needs to handle multiple collectors.  Most of the infrastructure is there

Comment 2 Susan McCourt

2012-01-26 17:31:22 EST

I don't expect to have mockups from Linda on this issue until after M2.  Should be an RC1 item.

Comment 3 Susan McCourt

2012-02-01 14:01:07 EST

while doing this, consider whether there's anything to be gained from making these "panes" <section> elements in HTML and therefore the header/parameter collector would be a <header> for a <section>.  I believe that the HTML generated for the settings and repo pages are using sections, but I know for sure that the auxiliary panes (favorites, git status panes, etc.) are creating their own.

We could consider changing

mUtil.createPaneHeading

to be something like

mUtil.createSection 

and then you'd get all the stuff in a common template.

Comment 4 Susan McCourt

2012-02-07 02:34:29 EST

pushed fix.
The main changes here are:
- main toolbar slideout is now always on left and colored gray (per Linda mockups). There is still some tweaking to do of width, margin, buttons, etc. which is covered in other bugs.
- section slideouts can now be used. There is some tweaking of the layout I need to do
- if a slideout is not available, a dijit tooltip dialog is used near the command

I verified the following:

- existing command slideouts are still working for main toolbar
- home grown slideouts (text find/replace and search preview) are still working
- implemented "Add" on the favorites section heading as a slideout
- for commands that appear in toolbars and menus, I verified that the command parameter collector works for both. (for example, New Folder is a slideout in the main toolbar and a tooltip dialog in the rows.)

Szymon - the slideout stuff "just works" for favorites, git status, etc. because they use mUtil.createPaneHeading to create common HTML templates for the section heading, commands, and slideouts. Since you are generating your HTML in your own way, we have some work to get your stuff using section slideouts. The command parameter collector is using CSS classes to "find" the appropriate slideout given a dom node. So you need to make sure a template similar to that in mUtil.createPaneHeading is in place. Ideally you would just call createPaneHeading so we can evolve this utility method if it's not right for your needs. I can work with you tomorrow on all this.