Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367199

Summary: mCommands.ParametersDescription does not work for non-menu object commands
Product: [ECD] Orion Reporter: Szymon Brandys <Szymon.Brandys>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 0.4 RC1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Szymon Brandys CLA 2011-12-20 10:01:50 EST 
I wanted to refactor git "new branch" command to use mCommands.ParametersDescription. I noticed that the prompt is not shown as long as the command is in the main toolbar. When I move the command to 'More' section, the param prompt is shown.
Comment 1 Susan McCourt CLA 2011-12-20 11:08:15 EST 
object level commands are currently only implemented for menus.  I knew that we didn't want the user to go up to a slideout from deep in a list, so I tried tooltip dialogs for the menu commands, and we probably want to use this technique for object commands.
Comment 2 Susan McCourt CLA 2012-02-07 02:55:02 EST 
this was fixed with the refactoring for bug 367220.

(In reply to comment #1)
> object level commands are currently only implemented for menus.  I knew that we
> didn't want the user to go up to a slideout from deep in a list, so I tried
> tooltip dialogs for the menu commands, and we probably want to use this
> technique for object commands.

We now look for toolbar and section slideouts.
If we don't find them, we generate a parameter collector in a tooltip dialog.

With the new repo page, i didn't find a case of an "object" command that could show this works, but you can see it in the section commands since the slideouts aren't yet implemented for the repo page.

Click on "New branch" in the branches section heading and you'll get a tooltip dialog prompting you for the branch that shows near the branch command.  (Before, it just reverted to the prompt).  

Once section slideouts are added to the repo page, then this would change to use a section slideout.