Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367164

Summary: [target] NPE thrown by a location containing .war file that isn't a bundle
Product: [Eclipse Project] PDE Reporter: Ankur Sharma <ankur_sharma>
Component: UIAssignee: Ankur Sharma <ankur_sharma>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public
Version: 3.8   
Target Milestone: 3.8 M5   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on: 355890    
Bug Blocks: 367796    
Attachments:
Description Flags
Patch none

Description Ankur Sharma CLA 2011-12-20 05:29:45 EST 
Steps to repro

1. Create a target with a location pointing to an Eclipse installation.
2. (By mistake) put a .war file in the plug-ins folder
3. Open Target pref page and edit this target

Throws NPE. Content page doesn't even renders correctly




eclipse.buildId=N20111218-2000
java.fullversion=JRE 1.6.0 IBM J9 2.4 Windows 7 amd64-64 jvmwa6460sr9-20110624_85526 (JIT enabled, AOT enabled)
J9VM - 20110624_085526
JIT  - r9_20101028_17488ifx17
GC   - 20101027_AA
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=en_IN
Command-line arguments:  -os win32 -ws win32 -arch x86_64

Error
Tue Dec 20 15:26:54 IST 2011
An internal error has occurred.

java.lang.NullPointerException
	at org.eclipse.jface.viewers.StyledString.append(StyledString.java:264)
	at org.eclipse.jface.viewers.StyledString.append(StyledString.java:172)
	at org.eclipse.pde.internal.ui.shared.target.StyledBundleLabelProvider.appendBundleInfo(StyledBundleLabelProvider.java:169)
	at org.eclipse.pde.internal.ui.shared.target.StyledBundleLabelProvider.getStyledString(StyledBundleLabelProvider.java:85)
	at org.eclipse.pde.internal.ui.shared.target.StyledBundleLabelProvider.getText(StyledBundleLabelProvider.java:293)
	at org.eclipse.jface.viewers.ViewerComparator.getLabel(ViewerComparator.java:143)
	at org.eclipse.jface.viewers.ViewerComparator.compare(ViewerComparator.java:128)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup$4.compare(TargetContentsGroup.java:286)
	at org.eclipse.jface.viewers.ViewerComparator$1.compare(ViewerComparator.java:189)
	at java.util.Arrays.mergeSort(Arrays.java:2874)
	at java.util.Arrays.mergeSort(Arrays.java:2887)
	at java.util.Arrays.mergeSort(Arrays.java:2887)
	at java.util.Arrays.sort(Arrays.java:3251)
	at java.util.Arrays.sort(Arrays.java:3269)
	at org.eclipse.jface.viewers.ViewerComparator.sort(ViewerComparator.java:187)
	at org.eclipse.jface.viewers.AbstractTreeViewer.getSortedChildren(AbstractTreeViewer.java:635)
	at org.eclipse.jface.viewers.AbstractTreeViewer$1.run(AbstractTreeViewer.java:812)
	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:789)
	at org.eclipse.jface.viewers.TreeViewer.createChildren(TreeViewer.java:644)
	at org.eclipse.jface.viewers.AbstractTreeViewer.createChildren(AbstractTreeViewer.java:760)
	at org.eclipse.jface.viewers.AbstractTreeViewer.internalInitializeTree(AbstractTreeViewer.java:1540)
	at org.eclipse.jface.viewers.TreeViewer.internalInitializeTree(TreeViewer.java:833)
	at org.eclipse.jface.viewers.AbstractTreeViewer$5.run(AbstractTreeViewer.java:1524)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1443)
	at org.eclipse.jface.viewers.TreeViewer.preservingSelection(TreeViewer.java:403)
	at org.eclipse.jface.viewers.StructuredViewer.preservingSelection(StructuredViewer.java:1404)
	at org.eclipse.jface.viewers.CheckboxTreeViewer.preservingSelection(CheckboxTreeViewer.java:416)
	at org.eclipse.jface.viewers.AbstractTreeViewer.inputChanged(AbstractTreeViewer.java:1517)
	at org.eclipse.jface.viewers.ContentViewer.setInput(ContentViewer.java:280)
	at org.eclipse.jface.viewers.StructuredViewer.setInput(StructuredViewer.java:1690)
	at org.eclipse.pde.internal.ui.shared.target.TargetContentsGroup.setInput(TargetContentsGroup.java:955)
	at org.eclipse.pde.internal.ui.wizards.target.TargetDefinitionContentPage$4.runInUIThread(TargetDefinitionContentPage.java:266)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.pde.internal.ui.preferences.TargetPlatformPreferencePage.handleEdit(TargetPlatformPreferencePage.java:489)
	at org.eclipse.pde.internal.ui.preferences.TargetPlatformPreferencePage.access$4(TargetPlatformPreferencePage.java:483)
	at org.eclipse.pde.internal.ui.preferences.TargetPlatformPreferencePage$9.widgetSelected(TargetPlatformPreferencePage.java:321)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:240)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
	at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
	at org.eclipse.jface.window.Window.open(Window.java:801)
	at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.open(WorkbenchPreferenceDialog.java:215)
	at org.eclipse.ui.internal.handlers.ShowPreferencePageHandler.execute(ShowPreferencePageHandler.java:54)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:241)
	at org.eclipse.ui.internal.actions.CommandAction.runWithEvent(CommandAction.java:157)
	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1053)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4165)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3754)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2701)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2665)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2499)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:679)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:668)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
	at java.lang.reflect.Method.invoke(Method.java:611)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1433)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1409)
Comment 1 Ankur Sharma CLA 2011-12-20 05:46:52 EST 
Another way to generate same stack trace

1. Put a war file in a directory
2. try to add this as directory location to a target
3. NPE throws as soon next is pressed
Comment 2 Curtis Windatt CLA 2011-12-20 16:21:29 EST 
I don't get this NPE, but I am encountering problems where the target platform complains about a missing bundle if I replace a .jar bundle with a .war file.
Comment 3 Curtis Windatt CLA 2011-12-22 09:36:37 EST 
Any updates here Ankur?
Comment 4 Ankur Sharma CLA 2011-12-26 06:37:57 EST 
Created attachment 208802 [details]
Patch

The problem is of course when reading the files and creating bundles (objects) out of them. A .war file does have a Manifest file, but there is no sysmbolic name, hence the missing entry creates NPE later on. Since, a war file is not a valid bundle (in this case), an exception should be thrown.

To fix this, we need to add the check that if no plugin.xml was found and nor the symbolic-name then the exception should be thrown. Attaching the patch for the same.
Comment 5 Curtis Windatt CLA 2012-01-03 16:11:15 EST 
So the problem exists when the target has a war file that isn't a bundle. The fix should be backported to wherever bug 355890 ends up.
Comment 6 Curtis Windatt CLA 2012-01-03 16:26:21 EST 
Patch fixes the NPE. If a symbolic name is added to the war file, but no other headers, PDE still handles it as a bundle correctly.

Pushed the fix to master.
Comment 7 Curtis Windatt CLA 2012-01-24 12:31:46 EST 
Verified in I20120123-1800

This change did surface 368753 which will be fixed for M6