Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 367153

Summary:

synchronization utilities

Product:

z_Archived

Reporter:

Nicolas Bros <nicolas.bros>

Component:

EMF-Facet

Assignee:

Gregoire Dupe <gdupe>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

emft.facet-inbox, gdupe

Version:

unspecified

Flags:

gdupe: juno+

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
org.eclipse.emf.facet.util.ui plug-in	gdupe: iplog+

Description Nicolas Bros

2011-12-20 03:34:53 EST

There are a bunch of synchronization helpers in org.eclipse.emf.facet.widgets.nattable.internal.SynchronizedNatTableWidget.

I'd like to be able to use them for a new JUnit-testable dialog, and future dialogs that are written to be testable with pure JUnit tests (without SWTBot).

So these helpers should be extracted to another plug-in from which then can be accessed internally (by EMF Facet code).

Comment 1 Gregoire Dupe

2011-12-20 04:55:27 EST

Created attachment 208596 [details]
org.eclipse.emf.facet.util.ui plug-in

This new plug-in (org.eclipse.emf.facet.util.ui) contains code copied from org.eclipse.emf.facet.widgets.nattable.internal.SynchronizedNatTableWidget and code written by my self.

(a) I, Gregoire Dupe, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.

Comment 2 Gregoire Dupe

2011-12-20 04:58:43 EST

Comment on attachment 208596 [details]
org.eclipse.emf.facet.util.ui plug-in

I've committed this new plug-in. (and added the missing about.html file)

Committed revision 1341.

Comment 3 Gregoire Dupe

2011-12-20 05:20:04 EST

I've modified of SynchronizedNatTableWidget to use SynchronizedComposite.

Committed revision 1342.

I still have: 
- to fix warnings in org.eclipse.emf.facet.util.ui
- to check that unit tests run properly in hudson (on my computer the runtime eclipse doesn't shut down it self.)

Comment 4 Nicolas Bros

2011-12-20 06:14:21 EST

note: I think these synchronization issues are cross-cutting concerns that would be a good fit for aspect programming with i.e. AspectJ : we could automatically wrap methods with the appropriate synchronization code, based on annotations for example.

Comment 5 Gregoire Dupe

2011-12-20 08:10:47 EST

The commit for this bug have broken the build:

 Missing requirement: EMF Facet NatTable Widget (Incubation) 0.2.0.v201112201258 (org.eclipse.emf.facet.widgets.nattable 0.2.0.v201112201258) requires 'bundle org.eclipse.emf.facet.util.ui 0.2.0' but it could not be found

I'll add org.eclipse.emf.facet.util.ui in a feature.

Comment 6 Gregoire Dupe

2011-12-20 08:13:43 EST

(In reply to comment #5)
> I'll add org.eclipse.emf.facet.util.ui in a feature.

I've added the plug-in org.eclipse.emf.facet.util.ui in the feature org.eclipse.emf.facet.util.feature

Committed revision 1343.

Comment 7 Gregoire Dupe

2011-12-22 04:34:00 EST

(In reply to comment #4)
> note: I think these synchronization issues are cross-cutting concerns that
> would be a good fit for aspect programming with i.e. AspectJ : we could
> automatically wrap methods with the appropriate synchronization code, based on
> annotations for example.

I already use AspectJ within Eclipse: it was a bit complicated. I'm not sure, I would like to repeat the experience.

Comment 8 Gregoire Dupe

2013-05-24 04:19:30 EDT

I assume that this bug can be closed.