Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366975

Summary: remove org.slf4j.api 1.5.11
Product: [Tools] Orbit Reporter: David Williams <david_williams>
Component: bundlesAssignee: Orbit Bundles <orbit.bundles-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gunnar
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description David Williams CLA 2011-12-16 15:09:23 EST
It is a little aggressive to remove this "old" bundle due to our retention policy, but it is currently causing a build failure, presumably since some other, old logback bundles were removed. 

The failing message is
= = = = =
[orbit-set1] /opt/public/orbit/basebuilders/R37_M7/org.eclipse.releng.basebuilder/plugins/org.eclipse.pde.build_3.7.0.v20110418/scripts/genericTargets.xml:111:
Processing inclusion from feature
org.eclipse.orbit.build.feature.set1: Bundle
org.slf4j.api_1.5.11.v20100519-1910 failed to resolve.:
[orbit-set1] 		 Host plug-in org.slf4j.impl.StaticLoggerBinder_0.0.0 has
not been found
= = = = =

On mailing list, Gunnar has said:
= = = = =
SLF4J 1.5.11 has been in the build for a long time and I didn't touch
it that time. I removed an older Logback implementation which might be
a cause. I think the message is mis-leading, though. There is not
really a host plug-in called "org.slf4j.impl.StaticLoggerBinder".
There is a required capability/p2 requirement, though.

SLF4J 1.5 is known to break when no such implementation is available.
We had that issue back in Galileo. I wonder if I should just pull
SLF4J from active builds as well. It's really outdated anyway and now
is IMHO a good time to pull old things so that people can adapt for
M5.
= = = = =

I'm in favor of removing it too. If someone needs the old one, is will be retained in our previous R-builds so they can get it from there. 

I suppose another option is to add back the "old" logging bundle that "provided" the capabilities 
For the record, it appears it would be 
ch.qos.logback.slf4j
version 0.9.19

both more recent versions of ch.qos.logback.slf4j (0.9.27 and 0.9.24) provide 1.6.1 of the capability

provides.0.namespace = org.slf4j.api
provides.0.name = org.slf4j.impl.StaticLoggerBinder
provides.0.version = 1.6.1

? Is that another bug, that they both provide 1.6.1?
Comment 1 David Williams CLA 2011-12-16 15:11:40 EST
Unless I hear from you in about 3 minutes, I'm going to comment it out in the feature, so we can get a clean I build to promote.
Comment 2 David Williams CLA 2011-12-16 15:20:52 EST
Looks like Gunnar beat me to it (a day or two ago :) but not "released for build" yet (i.e. updated map file). The "set" of bundles removed, were 

   <plugin
         id="org.slf4j.api"
         download-size="0"
         install-size="0"
         version="1.5.11.qualifier"
         unpack="false"/>

   <plugin
         id="org.slf4j.ext"
         download-size="0"
         install-size="0"
         version="1.5.11.qualifier"
         unpack="false"/>

   <plugin
         id="org.slf4j.jcl"
         download-size="0"
         install-size="0"
         version="1.5.11.qualifier"
         unpack="false"/>

   <plugin
         id="org.slf4j.jul"
         download-size="0"
         install-size="0"
         version="1.5.11.qualifier"
         unpack="false"/>

   <plugin
         id="org.slf4j.log4j"
         download-size="0"
         install-size="0"
         version="1.5.11.qualifier"
         unpack="false"/>
Comment 3 Gunnar Wagenknecht CLA 2011-12-16 15:28:55 EST
Sorry. I'm in the middle of migrating from my old machine to a new one. I did beat you only by a few minutes. But I couldn't release because I had to install the Releng tools again. Now running on a 64bit Eclipse build. :)
Comment 4 Gunnar Wagenknecht CLA 2011-12-16 15:30:50 EST
Released.