Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366954

Summary:	Shift and Enter in the commit message window -annoyingly- always causes a commit
Product:	[Technology] Subversive	Reporter:	Missing name <j.p.cranendonk>
Component:	UI	Assignee:	Igor Burilo <igor.burilo>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Missing name

2011-12-16 11:35:06 EST

Build Identifier: 20110218-0911

When committing a change, Eclipse will pop up a window requesting a commit message. In this window, enter goes to the next line, and shift-enter commits the changes.
Since in most applications this is the other way round, or shift-enter is at a minimum a way to go to the next line, it often happens that one accidently commits a change with a uncomplete commit message, which being version control usually can't be changed after the fact. This is highly annoying.
This happens to other people too:
http://stackoverflow.com/questions/5691842/change-subclipse-commit-behaviour
http://stackoverflow.com/questions/7418330/in-eclipse-how-to-make-shiftenter-to-not-send-a-commit-immediately
http://forums.xkcd.com/viewtopic.php?f=11&t=61232


Reproducible: Always

Steps to Reproduce:
1. Start a commit
2. Type half a commit message
3. Type shift-enter

Comment 1 Missing name

2011-12-16 11:38:07 EST

I guess I didn't actually propose a sollution. That would be to disable shift-enter by default, and allow it to be enabled via the preferences (for those who have a use for it).

Comment 2 Alexander Gurov

2011-12-18 05:06:49 EST

Since it is the default SWT behaviour for the "default button", disabling it will cause the insignificant visual side effect: the "Ok" button won't look as the "default" button looks. There are other ways around but they'll cause a much more significant issues (like loosing current control focus, for example).