Bugzilla – Full Text Bug Listing
| Summary: | Content assist provider input needs to be escaped | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | John Arthorne <john.arthorne> |
| Component: | Client | Assignee: | John Arthorne <john.arthorne> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | mamacdon |
| Version: | 0.4 | ||
| Target Milestone: | 0.4 M2 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=47b0e17eb9884e45178f8fd235861358d1fe0fd1 Mark, can you just double-check that this is matches our general approach for user input. Is there anything more than this needed? (In reply to comment #1) > http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=47b0e17eb9884e45178f8fd235861358d1fe0fd1 > > Mark, can you just double-check that this is matches our general approach for > user input. Is there anything more than this needed? Nope, this is fine. |
0.4 M1 Any string provided by a content assist plugin simply gets inserted into a div.innerHTML. For example if I have a provider like this: getKeywords: function(prefix, buffer, selection) { return [ "<b>Gotcha!</b>" ]; } Then the content assist proposal appears in bold. This input should be escaped.