Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366916

Summary:

[jface] GraphViewer does not handle post selection events

Product:

[Tools] GEF

Reporter:

Erdal Karaca <erdal.karaca.de>

Component:

GEF-Legacy Zest

Assignee:

gef-inbox <gef-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

steeg

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Initial post selection events notification.	steeg: iplog+

Description Erdal Karaca

2011-12-16 02:43:01 EST

The GraphViewer does not handle post selection events. This is needed e.g. by the eclipse properties view.

Comment 1 Erdal Karaca

2011-12-16 02:50:10 EST

Created attachment 208481 [details]
Initial post selection events notification.

I am not sure if this is the right place for post selection events notifications. But that makes the properties view work as expected.

Comment 2 Erdal Karaca

2011-12-16 02:53:52 EST

BTW. I am not sure why you define your own listener lists as the base Viewer classes already have an attribute to collect the listeners.
Specifically, I would have thought that you would be reusing e.g.

- StructuredViewer.postSelectionChangedListeners
- Viewer.selectionChangedListeners

Comment 3 Fabian Steeg

2011-12-18 18:24:21 EST

Thanks for the patch.

Fixed in 2.0 master and 1.x HEAD, see GraphViewerTests#testPostSelectionListener