Bugzilla – Full Text Bug Listing
| Summary: | org.eclipse.jpt.core.internal.facet.JpaFacetDataModelProvider has no dispose (not cleaning up resources) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] Dali JPA Tools | Reporter: | Kevan Holdaway <kholdaway> | ||||||
| Component: | General | Assignee: | Neil Hauge <neil.hauge> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P2 | CC: | cbridgha, ccc, neil.hauge | ||||||
| Version: | 2.3.3 | ||||||||
| Target Milestone: | 3.0.3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 387992 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kevan Holdaway
If this is fixed in Head, please backport to 2.3.x if possible. Chuck...Do we have any plans for a WTP 3.2.6 release? Chuck...Do we have any plans for a WTP 3.2.6 release? Can I get an update on this? Is there a plan to fix this in 3.0 maintenance? I would think this could be backported to 3.0.x. Targeting to 3.0.2. Created attachment 210764 [details]
Add dispose method.
Upon adding the dispose() method to JpaFacetDataModelProvider I discovered that there appears to be a hole in data model provider disposal across WTP on facet addition, including Dali. From what I can tell, none of the J2EE data model providers dispose() methods are being called when adding a facet from the Facets project properties page. I'm not sure yet if this is a framework issue or something that clients are doing wrong, or perhaps I am just missing something. In either case, the attached patch takes a step in the right direction so that when the framework does call dispose() (such as on facet version modification), we respond appropriately. This patch should at least bring us on par with much of the rest of WTP.
I noticed that too, however, we are using the JPA facet page in a wizard that does call dispose. The Facet Framework should also be calling dispose from the Dynamic Web Project Wizard if it is not. Either way, the facet page should assume that dispose is always called (or its a bug on the code that uses the facet page). Created attachment 210814 [details]
minor update
This is a minor update to avoid another listener leak that previously existed.
(In reply to comment #7) > I noticed that too, however, we are using the JPA facet page in a wizard that > does call dispose. The Facet Framework should also be calling dispose from the > Dynamic Web Project Wizard if it is not. Either way, the facet page should > assume that dispose is always called (or its a bug on the code that uses the > facet page). Okay, so this would be more useful in the adopter setting. Would you like for me to try and get this pushed into 3.0.2 RC3? If it is a "hot" adopter issue then we can probably make it happen. If a WTP 3.2.5 patch is what is needed, I can help with the necessary committer steps for that. At this point, we are based on WTP 3.2.5. So we will need a patch for that. I know we build patches and this one would need to be included. I think Carl Anderson handles those. (In reply to comment #10) > At this point, we are based on WTP 3.2.5. So we will need a patch for that. I > know we build patches and this one would need to be included. I think Carl > Anderson handles those. OK...let's focus on that (3.2.5 patch) for now then and we'll put this into Dali 3.0.3 so it is there when you pick up WTP 3.3.x. This patch has been committed to 3.0.3 and 3.2 streams. Need to open clone bug for 3.2.5P stream. Clone bug has been created...marking this as fixed. |