Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366805

Summary:	Extdoc shows full qualified name of selected variable, but not the type
Product:	z_Archived	Reporter:	Johannes Lerch <lerch>
Component:	Recommenders	Assignee:	Marcel Bruch <marcel.bruch>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Johannes Lerch

2011-12-15 08:41:06 EST

Reproduce: Select a variable. Extdoc View shows the full qualified name in title bar. This name does not include the important information what type the variable has. Same holds for the hover.

Comment 1 Marcel Bruch

2012-01-15 08:52:18 EST

The view now holds the SimpleName of the type, i.e., Composite or IWorkbenchHelp.

Example (as is today):

public class MyDialog extends Dialog {

	@Override
	protected Control createDialogArea(final Composite parent) {
            IWorkbenchHelpSystem h<CURSOR>elp = null;

--> Header now shows:

IWorkbenchHelp org.my.demo.MyDialog.createDialogArea(Composite).help




 Is this what you want to see? Or do you want the fully qualified type name?

Comment 2 Marcel Bruch

2012-02-02 01:30:09 EST

ping?

Comment 3 Johannes Lerch

2012-02-02 03:30:27 EST

SimpleName should be enough. You may want to have the SimpleName clickable too ;-)
I think the enclosing method should not be shown as part of the variable name. At least not the parameters as they have nothing to do with the local variable.

Comment 4 Marcel Bruch

2012-02-02 03:44:03 EST

Thanks for getting back to me on this. 
So, for the given scenario what would you expect?  Can you provide a few simple examples?

Comment 5 Johannes Lerch

2012-02-02 04:40:08 EST

In your example it shuld be enough to show:
IWorkbenchHelp help

It's not possible to distinguish a local variable from a field in this representation, but the full representation is very unfamiliar. How important is the distinction? In most cases the user already knows where the element is located he selects and the title bar should give a quick reminder what was clicked only. To be quick the label must be short and the representation familiar.

Comment 6 Marcel Bruch

2012-02-04 07:27:47 EST

Label computation for locals changed to:

<Type> <name> - <fully qualified method string>

Just type + name looked too short for my personal taste - but maybe one just hast to get used to it. We'll see :) Reopen if you like to have more/other changes.

http://git.eclipse.org/c/recommenders/org.eclipse.recommenders.git/commit/?id=d1391361df09e17c46ed245c825d01710be673c8

Comment 7 Marcel Bruch

2012-06-09 15:12:09 EDT

Set target milestone for fixed bugs to 1.0

Comment 8 Marcel Bruch

2012-06-09 15:12:15 EDT

Set target milestone for fixed bugs to 1.0