Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366771

Summary:

[converter] Converter fails to convert a CDT makefile project

Product:

[Tools] CDT

Reporter:

Anna Dushistova <anna.dushistova>

Component:

cdt-build

Assignee:

Doug Schaefer <cdtdoug>

Status:

RESOLVED FIXED

QA Contact:

Andrew Gvozdev <angvoz.dev>

Severity:

normal

Priority:

CC:

cdtdoug

Version:

8.0

Target Milestone:

8.1.0

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch that fixes the problem for a makefile project	none
test plugin	none
patch against the most recent master	cdtdoug: iplog+, anna.dushistova: review?

Description Anna Dushistova

2011-12-14 18:44:05 EST

I am trying to use converter extension to convert a makefile project to my toolchain but haven't had any luck.

I experienced two problems so far:
1) The "Convert To..." action only deals with project types, which is "null" for a makefile project. Documentation to the extension point however suggests that I could use any of (project type,toolchain id, tool id,builder);
2) If I use a toolchain id, on the "Toolchain Editor" property page I can see my wizard page after I select my toolchain. Unfortunately wizard fails to finish because of the NPE at org.eclipse.cdt.managedbuilder.ui.wizards.MBSWizardHandler.<init>(MBSWizardHandler.java:310), which is again caused by the project type being null.

Comment 1 Anna Dushistova

2012-01-21 17:42:21 EST

Created attachment 209876 [details]
Patch that fixes the problem for a makefile project

Comment 2 Anna Dushistova

2012-01-21 17:44:16 EST

The attached patch adds an ability to use a toolchain id in the converter action.

Comment 3 Anna Dushistova

2012-01-25 10:10:33 EST

Created attachment 210054 [details]
test plugin

Comment 4 Anna Dushistova

2012-02-07 20:24:22 EST

Created attachment 210704 [details]
patch against the most recent master

Comment 5 Doug Schaefer

2012-04-27 12:18:01 EDT

Hi Anna, I finally have my commit rights back and time to look at this. Can you submit it to Gerrit? It'll be easier for me to review there. Thanks!

Comment 6 Anna Dushistova

2012-05-01 16:09:53 EDT

Is there any instruction on how to do it?

Comment 7 Doug Schaefer

2012-05-01 16:16:15 EDT

Yes, this has been posted to the cdt-dev list a few times. A few committers and contributors have gone through the process and it's been refined a little. Always feel free to ask questions to the list.

http://wiki.eclipse.org/CDT/git

It's the last section on this page.

Comment 8 Anna Dushistova

2012-05-01 18:08:04 EDT

Doug, the last section is how to create patches with Git.
Anyway, I failed miserably to set up a Gerrit workflow on my current machine.
I am getting a 
fatal: '/org.eclipse.cdt.git': not a Gerrit project
fatal: The remote end hung up unexpectedly.

Comment 9 Doug Schaefer

2012-05-04 10:09:07 EDT

Patch applied: https://git.eclipse.org/r/5778