Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366741

Summary:	how should extension points specify images?
Product:	[ECD] Orion	Reporter:	Susan McCourt <susan>
Component:	Client	Assignee:	Project Inbox <orion.client-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	antonm, mamacdon, Michael_Rennie
Version:	0.3
Target Milestone:	7.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Susan McCourt

2011-12-14 13:42:29 EST

I thought we had a bug for this, because I remember a discussion in one (probably when I was working on sprites).

We have several extension points that specify images.

orion.navigate.command
orion.edit.command
orion.file.contenttype

Currently those images are specified by URL.
We had discussed and dimissed the idea of using a CSS class because of the security risks of letting a plugin contribute CSS.

We considered using a data URI so that the icon could be embedded.  The downside is that a plug-in has to take an extra step to generate one.

We also considered leaving the spec as a URL.  We could run some code to see if there is data, and if there is not, we could generate a data URI from the plugin's image.  The downside is complexity on our side, and the time spent doing so.

Whatever we do I think these three extensions should use the same technique.  I left them all as image URL's for now, which are fed to an image.src

Comment 1 Anton McConville

2015-05-08 10:20:13 EDT

This has evolved, and I don't believe is a problem area anymore.