Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366662

Summary:	[flex] ViewerInputService should take viewer interface as constructor.
Product:	[Eclipse Project] Platform	Reporter:	Pawel Piech <pawel.1.piech>
Component:	Debug	Assignee:	Pawel Piech <pawel.1.piech>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Michael_Rennie
Version:	3.8	Flags:	Michael_Rennie: review+
Target Milestone:	3.8 M5
Hardware:	PC
OS:	Linux
Whiteboard:

Description Pawel Piech

2011-12-14 00:31:15 EST

I'm writing unit tests in another project which simulate debugger views with virtual viewer.  But, I've run into a problem trying to reuse ViewerInputService with the virtual viewer because it assumes the viewer to be a JFace tree model viewer.  Changing it to use ITreeModelViewer is backward compatible.

Comment 1 Pawel Piech

2011-12-14 00:37:35 EST

Mike, please have a look.

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/

Comment 2 Pawel Piech

2011-12-14 15:00:51 EST

(In reply to comment #1)
> Mike, please have a look.
> 
> http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/

Oops, make that http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=ff153112a45c47312d0bea81ca5ef1359064cc22

Comment 3 Michael Rennie

2011-12-15 10:11:39 EST

(In reply to comment #2) 
> Oops, make that
> http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=ff153112a45c47312d0bea81ca5ef1359064cc22

That's still the wrong commit :)

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=0e2f24f03fd6c3409212625539b3df42755063c7

which looks good.