Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366606

Summary: [Compatibility] Failures in ContextsTestSuite
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: RESOLVED WORKSFORME QA Contact:
Severity: normal    
Priority: P4 CC: Lars.Vogel, Michael_Rennie, remy.suen
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on:    
Bug Blocks: 366451, 381873    
Attachments:
Description Flags
failure stack traces none

Description Paul Webster CLA 2011-12-13 14:10:23 EST
Created attachment 208331 [details]
failure stack traces

Tests: 9/9 Errors: 0 Failures: 4
Comment 1 Paul Webster CLA 2011-12-13 14:12:27 EST
page.showView(partid) creates and activated the part, but it doesn't appear to update the active contexts.

Failed:
org.eclipse.ui.tests.contexts.Bug74990Test.testPartIdSubmission()
org.eclipse.ui.tests.contexts.PartContextTest.testBasicContextActivation()
org.eclipse.ui.tests.contexts.PartContextTest.testContextActivation()
org.eclipse.ui.tests.contexts.PartContextTest.testPageBookPageContextActivation()
Comment 2 Remy Suen CLA 2011-12-14 13:35:37 EST
(In reply to comment #1)
> org.eclipse.ui.tests.contexts.PartContextTest.testBasicContextActivation()
> org.eclipse.ui.tests.contexts.PartContextTest.testContextActivation()
> org.eclipse.ui.tests.contexts.PartContextTest.testPageBookPageContextActivation()

If the event is spun, then these tests pass for me. This is because our context changes are dispatched asynchronously by the UpdateExpression in ContextService.

Bug 366625 has a similar problem but will need the change for bug 348920 reverted first because the N copies of ContextAuthority is causing problems.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ec87e24a07c23cb6144b4cdb77bd3303b7530171
Comment 4 Paul Webster CLA 2012-03-01 21:27:06 EST
It causes wonkiness when you have 2 workbench windows open.

I've reverted the change in master.

PW
Comment 5 Eric Moffatt CLA 2012-04-17 13:39:31 EDT
Does this cause functional issues or is it just that the tests are failing ?

If the latter then we should likely defer...
Comment 6 Paul Webster CLA 2012-04-18 08:52:09 EDT
This is a functional issue, that can effect anyone using o.e.ui.contexts (keybindings, most of Debug and CDT, etc).

PW
Comment 7 Paul Webster CLA 2012-04-20 13:59:19 EDT
This is down to org.eclipse.ui.tests.contexts.Bug74990Test.testPartIdSubmission()

It can be deferred to 4.3

PW
Comment 8 Lars Vogel CLA 2016-04-20 12:16:51 EDT
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.