Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 366535

Summary:	Template comments quick fixes upset Acceleo editor
Product:	[Modeling] Acceleo	Reporter:	William Piers <william.piers>
Component:	Core	Assignee:	Project Inbox <acceleo-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	laurent.goubet
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/70091 https://git.eclipse.org/c/acceleo/org.eclipse.acceleo.git/commit/?id=da8803dd97b179c9e72db77bae73d9f5d493e751
Whiteboard:

Description William Piers

2011-12-13 09:01:51 EST

When doing Alt + Shift + J, with the cursor on a template header, the comment is generated but the editor seems to be disconnected to its document:
When changing the selection, the line where the cursor is changes or disappear.
Other refactoring actions may have the same problem.

It seems to only happen under Windows.

Comment 1 Eclipse Genie

2016-04-07 05:17:28 EDT

New Gerrit change created: https://git.eclipse.org/r/70091

Comment 2 Laurent Goubet

2016-04-07 05:19:03 EDT

This issue was due to an erroneous handling of the line separator : we were inserting the comment "1" character before the caret, which is fine on linux (before the \n) but not on windows (between the \r and \n).

The document didn't manage properly having both \r and \r\n as separators.

Comment 3 Eclipse Genie

2016-04-08 05:58:13 EDT

Gerrit change https://git.eclipse.org/r/70091 was merged to [master].
Commit: http://git.eclipse.org/c/acceleo/org.eclipse.acceleo.git/commit/?id=da8803dd97b179c9e72db77bae73d9f5d493e751